Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release versions 3.3.0 and 5.1.0 #813

Closed
32 tasks done
yurnov opened this issue Dec 10, 2024 · 19 comments
Closed
32 tasks done

Release versions 3.3.0 and 5.1.0 #813

yurnov opened this issue Dec 10, 2024 · 19 comments

Comments

@yurnov
Copy link
Contributor

yurnov commented Dec 10, 2024

As Ansible 11 was released and included kubernetes.core collections 5.0.0 means that branch stable-5 become the default one for the most of users who install ansible comunity package as pip install ansible, and documentation from the branch stable-5 (more specifically, to the released versions 5.x.y from that branch) appeared in the ansible documentation site.

However, since Jun 10 when 5.0.0 was released, we have had a lot of smaller and bigger changes that are not included in any released version of the collection kubernetes.core, and some of them have even not been cherry-picked to the stable-5 branch, which led, for the example that ansible galaxy contains deprecated communication channels.

So, it's time to release a new release from the branch stable-5 (that should be 5.1.0) and, probably stable-3 (that should be 3.2.0 in this case) but it's less important.

SUMMARY

Release a new version 5.1.0

To do that, some PRs that weren't cherry-picked to stable-5 should be merged in that branch (label backport-5 to be added):

The listed above PRs are merged to main but don't have the label backport-5 and are missed in branch stable-5.

UPDATE: to achieve working CI, the following is required:

On top of that, the following PRs are to be merged into main:

And finally:

  • create PR into stable-3 with release 3.3.0, add a tag when merged;
  • create PR into stable-5 with release 5.1.0, do not forget to add 3.3.0 into changelog, add tag when merged;
  • create PR to main with port 5.1.0 update and change version in galaxy.yaml to 5.2.0-dev0 to easy see that it's not released version in the output of ansible-galaxy collection list when collection is installed from git.
  • notify @newsbot:ansible.im to include released versions 3.3.0 and 5.1.0 in the next Ansible Bullhorn.
ISSUE TYPE
  • Feature Idea
COMPONENT NAME

kubernetes.core

ADDITIONAL INFORMATION

I can create the above-mentioned PRs (in the "and finally" part) in the similar way as #746, but need support from maintainers with code review, merge and tags.

@yurnov
Copy link
Contributor Author

yurnov commented Dec 11, 2024

Backport of #767 to stable-3 created as #822 due to merge conflict resolved manually

@yurnov
Copy link
Contributor Author

yurnov commented Dec 11, 2024

backport of #774 to stable-5 created as #823 due to patchback bot fail

@yurnov yurnov changed the title Release version 5.1.0 with all changes in master since 5.0.0 and #800 Release versions 3.3.0 and 5.1.0 Dec 26, 2024
@yurnov
Copy link
Contributor Author

yurnov commented Dec 26, 2024

I have updated issue to reflect the actual status and additional effort

@yurnov
Copy link
Contributor Author

yurnov commented Jan 15, 2025

Updated with CI issue (linters), please find #848.

@abikouo, would you like to review that PR?

@yurnov
Copy link
Contributor Author

yurnov commented Jan 17, 2025

PR #802 requires actions from @b0z02003, and he didn't respond to a request from @abikouo. I think that this can be skipped in release 5.1.0 (alternatively, I can help with the rebase and testing part, if the PR author will allow me to commit to b0z02003/kubernetes.core)

@gravesm
Copy link
Member

gravesm commented Jan 17, 2025

I think we should skip it and do the release the beginning of next week.

@yurnov
Copy link
Contributor Author

yurnov commented Jan 17, 2025

I think we should skip it and do the release the beginning of next week.

Sure. Thanks, @gravesm for your (and @abikouo) valuable support with this issue, I didn't expect this amount of CI-related work.

Would it be ok if I create PRs for the remaining part?

@gravesm
Copy link
Member

gravesm commented Jan 17, 2025

Yeah, that would be great. Thanks for your help in pushing this forward.

@yurnov
Copy link
Contributor Author

yurnov commented Jan 17, 2025

Yeah, that would be great. Thanks for your help in pushing this forward.

Thanks, I will do in Monday.

BTW, would you please add skip-changelog to #860 and #859 to merge them?

@gravesm
Copy link
Member

gravesm commented Jan 17, 2025

BTW, would you please add skip-changelog to #860 and #859 to merge them?

They're both merged.

@yurnov
Copy link
Contributor Author

yurnov commented Jan 17, 2025

BTW, would you please add skip-changelog to #860 and #859 to merge them?

They're both merged.

sorry, my fault, I meant #855 and #856 that is backports of #831, they are still opened with failed CI on changelog

@gravesm
Copy link
Member

gravesm commented Jan 17, 2025

Ah, sorry, missed these.

@b0z02003
Copy link

PR #802 requires actions from @b0z02003, and he didn't respond to a request from @abikouo. I think that this can be skipped in release 5.1.0 (alternatively, I can help with the rebase and testing part, if the PR author will allow me to commit to b0z02003/kubernetes.core)

I'm so sorry for the late reply. I do understand if the PR skips the next release, in the mean time, I've just rebased it and added @yurnov as a contributor. I'll try to look for the failing integration test on my part today and, hopefully, I'll be able to provide you with a clean PR for this next release (still, I'll understand if you skip it).

@yurnov
Copy link
Contributor Author

yurnov commented Jan 18, 2025

PR #802 requires actions from @b0z02003, and he didn't respond to a request from @abikouo. I think that this can be skipped in release 5.1.0 (alternatively, I can help with the rebase and testing part, if the PR author will allow me to commit to b0z02003/kubernetes.core)

I'm so sorry for the late reply. I do understand if the PR skips the next release, in the mean time, I've just rebased it and added @yurnov as a contributor. I'll try to look for the failing integration test on my part today and, hopefully, I'll be able to provide you with a clean PR for this next release (still, I'll understand if you skip it).

Let see how it will work in monday

@yurnov
Copy link
Contributor Author

yurnov commented Jan 20, 2025

Hi @gravesm @abikouo,

during the weekend the CI part for #802 was completed, should we include this PR in the release? Could you please take a look?

Both options, to include this PR, or to release without and keep 802 and #786 for the next release will be fine for me.

@gravesm
Copy link
Member

gravesm commented Jan 20, 2025

Let's continue with the release as planned and leave these for the next release. We can probably try and plan on a 5.2.0 release in a month.

@yurnov
Copy link
Contributor Author

yurnov commented Jan 20, 2025

PR for 3.3.0 #863
PR for 5.1.0 #865

@yurnov
Copy link
Contributor Author

yurnov commented Jan 20, 2025

Releases 3.3.0 and 5.1.0 are live!

The remaining part is a post-5.1.0 update #866

@yurnov
Copy link
Contributor Author

yurnov commented Jan 21, 2025

Done

@yurnov yurnov closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants