Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM Migrate ec2_vpc_vgw* modules and tests #2299

Closed

Commits on Sep 19, 2024

  1. Initial commit

    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2977eb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a3c031 View commit details
    Browse the repository at this point in the history
  3. Rename collection (ansible-collections#12)

    * Rename core collection
    
    Rename references to ansible.amazon to amazon.aws.
    
    * Rename community.amazon to community.aws
    Fix pep8 line lengths for rewritten amazon.aws imports
    
    * Missed a path in shippable.sh
    * Dependency repos moved
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@235c5db
    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8d6d3ed View commit details
    Browse the repository at this point in the history
  4. Remove METADATA and cleanup galaxy.yml (ansible-collections#70)

    * Remove ANSIBLE_METADATA entirely, see ansible/ansible/pull/69454.
    Remove `license` field from galaxy.yml, in favor of `license_file`.
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@05672a6
    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    798d51b View commit details
    Browse the repository at this point in the history
  5. Collections related fixes for CI (ansible-collections#96)

    * Update module deprecations
    
    Switch version to `removed_at_date`
    
    * Don't install amazon.aws from galaxy
    
    We've been using galaxy to install amazon.aws in shippable, but that
    doesn't really work if we aren't publising faster. Get that collection
    from git so it is most up to date.
    
    * We need to declare python test deps now
    
    * missed a python dep
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@7cd211e
    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    acaae2d View commit details
    Browse the repository at this point in the history
  6. Update Examples with FQCN (ansible-collections#67)

    Updated module examples with FQCN
    
    Signed-off-by: Abhijeet Kasurde <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@98173ae
    Akasurde authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4139f4f View commit details
    Browse the repository at this point in the history
  7. Update module_utils paths to remove aws subdir (ansible-collections#23)

    Co-authored-by: Ezekiel Hendrickson <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@10853d9
    2 people authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    89cd03b View commit details
    Browse the repository at this point in the history
  8. Update docs (ansible-collections#99)

    * Update docs
    
    Remove .git from repo url so links in readme will generate correctly
    Add required ansible version
    Run latest version of add_docs.py
    Add version_added string to modules
    
    * galaxy.yml was missing authors
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@96ee268
    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    29684e7 View commit details
    Browse the repository at this point in the history
  9. Docs: sanity fixes (ansible-collections#133)

    Signed-off-by: Abhijeet Kasurde <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@059cf9e
    Akasurde authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    691dd71 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    938c150 View commit details
    Browse the repository at this point in the history
  11. Bulk migration to AnsibleAWSModule (ansible-collections#173)

    * Update comments to reference AnsibleAWSModule rather than AnsibleModule
    * Bulk re-order imports and split onto one from import per-line.
    * Add AnsibleAWSModule imports
    * Migrate boto 2 based modules to AnsibleAWSModule
    * Move boto3-only modules over to AnsibleAWSModule
    * Remove extra ec2_argument_spec calls - not needed now we're using AnsibleAWSModule
    * Remove most HAS_BOTO3 code, it's handled by AnsibleAWSModule
    * Handle missing Boto 2 consistently  (HAS_BOTO)
    * Remove AnsibleModule imports
    * Changelog fragment
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@818c6d2
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7e6fc6b View commit details
    Browse the repository at this point in the history
  12. Cleanup: Bulk Migration from boto3_conn to module.client() (ansible-c…

    …ollections#188)
    
    * Migrate from boto3_conn to module.client
    * Simplify error handling when creating connections
    * Simplify Region handling
    * Remove unused imports
    * Changelog
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@6bdf00d
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d56e819 View commit details
    Browse the repository at this point in the history
  13. Bulk import cleanup (ansible-collections#360)

    * Split imports and reorder
    * Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
    * Remove unused imports
    * Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
    * changelog
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@130cf3c
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    92e28d0 View commit details
    Browse the repository at this point in the history
  14. Bulk migration to fail_json_aws (ansible-collections#361)

    * Split imports and sort
    * Move camel_dict_to_snake_dict imports to ansible.module_utils.common.dict_transformations
    * Cleanup unused imports
    * Bulk migration to fail_json_aws
    * Changelog
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@6c88315
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a0faaf5 View commit details
    Browse the repository at this point in the history
  15. Move tests to using module_defaults (ansible-collections#368)

    * Bulk migration to module_defaults
    * Tests for missing creds/region
    * Move dms_identifier and dms_sg_identifier into defaults
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@365b6ef
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    569d167 View commit details
    Browse the repository at this point in the history
  16. Yet more integration test aliases file cleanup (ansible-collections#431)

    * More aliases cleanup
    * Mark ec2_classic_lb tests unstable
    * Add more comments about why tests aren't enabled
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@cb55efa
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2cb5ec6 View commit details
    Browse the repository at this point in the history
  17. Attempt to improve the stability of ec2_vpc_vgw and ec2_vpc_vpn (ansi…

    …ble-collections#162)
    
    * Add a custom Retry so we can retry when we receive 'The maximum number of mutating objects has been reached'
    * Update ec2_vpc_vpn unit test to use a connection with an AWSRetry decorator
    * changelog
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@79e0928
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    beb8930 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    7c51d23 View commit details
    Browse the repository at this point in the history
  19. Remove shippable references from repo

    This collection has been operating on Zuul CI for some weeks now
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4e0d83c
    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fa0ecdb View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    0f18403 View commit details
    Browse the repository at this point in the history
  21. Remove deprecated "facts" aliases (ansible-collections#814)

    Remove deprecated "facts" aliases
    
    SUMMARY
    Modules named "facts.py" that do not return ansible_facts were renamed to "info.py" in 2.9. Remove these aliases now that the deprecation period is over.
    This PR should be included in 3.0.0 of the collection.
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    *_facts.py
    
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Jill R <None>
    Reviewed-by: None <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@68aaa70
    jillr authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    29dd642 View commit details
    Browse the repository at this point in the history
  22. For consistency - add empty dependencies file to targets with no curr…

    …ent meta data (ansible-collections#1090)
    
    For consistency - add empty dependencies file to targets with no current meta data
    
    SUMMARY
    For consistency - add empty dependencies file to targets with no current meta data
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    tests/integration/targets
    ADDITIONAL INFORMATION
    
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@9638580
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9f1d646 View commit details
    Browse the repository at this point in the history
  23. ec2_vpc_vgw - Add support for purge_tags (ansible-collections#1232)

    ec2_vpc_vgw - Add support for purge_tags
    
    SUMMARY
    
    Adds support for purge_tags to ec2_vpc_vgw
    Updates behaviour so that tags must be explicitly set to {} to remove tags
    Updates ec2_vpc_vgw to pass tags as part of the VGW creation rather than tagging the VGW after creation.
    
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    ec2_vpc_vgw
    ec2_vpc_vgw_info
    ADDITIONAL INFORMATION
    
     return docs
     changelog
    
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@7ca53c7
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    616b104 View commit details
    Browse the repository at this point in the history
  24. Add some simple ec2_vpc_vgw_info integration tests to ec2_vpc_vgw tes…

    …ts (ansible-collections#1243)
    
    Add some simple ec2_vpc_vgw_info integration tests to ec2_vpc_vgw tests
    
    SUMMARY
    Add some simple ec2_vpc_vgw_info integration tests to ec2_vpc_vgw tests
    Not the most thorough tests, but tests the basic behaviour and gives a framework for further tests when someone makes a change.
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    ec2_vpc_vgw_info
    ADDITIONAL INFORMATION
    
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@42ecfd3
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0be96e7 View commit details
    Browse the repository at this point in the history
  25. ec2_vpc_vgw_info - update to not throw an error when run in check_mode (

    ansible-collections#1331)
    
    ec2_vpc_vgw_info - update to not throw an error when run in check_mode
    
    SUMMARY
    fixes: ansible-collections#137
    ec2_vpc_vgw_info currently throws an error when run in check_mode (it's using "DryRun") this unexpected and undocumented behaviour, and is the same practical effect as not supporting check_mode at all.
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    plugins/modules/ec2_vpc_vgw_info.py
    ADDITIONAL INFORMATION
    
    Reviewed-by: Joseph Torcasso <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@ed4165d
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cbd9193 View commit details
    Browse the repository at this point in the history
  26. Update extends_documentation_fragment with amazon.aws.boto3 (ansible-…

    …collections#1459)
    
    Update extends_documentation_fragment with amazon.aws.boto3
    
    Depends-On: ansible/ansible-zuul-jobs#1654
    SUMMARY
    
    As per ansible-collections#985 add amazon.aws.boto3.
    
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    
    several
    
    Reviewed-by: Jill R <None>
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Markus Bergholz <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@bd3c03f
    alinabuzachis authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f04874a View commit details
    Browse the repository at this point in the history
  27. Fix broken ec2_vpc_vgw tests (ansible-collections#1579)

    Fix broken ec2_vpc_vgw tests
    
    SUMMARY
    The APIs are no longer consistently returning deleted attachments.  Accept both the attachment being listed but marked 'deleted', and not being listed.
    Amazon's APIs used to be very slow to update this, making waiting for it a bad idea.
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    ec2_vpc_vgw
    ADDITIONAL INFORMATION
    
    Reviewed-by: Markus Bergholz <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@cea2ab5
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3da5b85 View commit details
    Browse the repository at this point in the history
  28. Fix non-matching defaults in docs (ansible-collections#1576)

    Fix non-matching defaults in docs
    
    Depends-On: ansible-collections#1579
    SUMMARY
    Fix various non-matching default values exposed by ansible/ansible#79267.
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    various
    
    Reviewed-by: Markus Bergholz <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@15568f0
    felixfontein authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7d37617 View commit details
    Browse the repository at this point in the history
  29. Ansible User-Agent identification for community.aws (ansible-collecti…

    …ons#1632)
    
    Ansible User-Agent identification for community.aws
    
    SUMMARY
    
    The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0
    
    ISSUE TYPE
    
    Feature Pull Request
    
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Bikouo Aubin <None>
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@a8cbce2
    abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a147f19 View commit details
    Browse the repository at this point in the history
  30. Cleanup headers and imports (ansible-collections#1738)

    Cleanup headers and imports
    
    SUMMARY
    Mass update of imports, docs fragments and file headers
    
    Many of the amazon.aws module_utils and docs fragments got moved about, update community.aws to reflect this.
    Consistently apply the comment headers as documented at https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
    
    ISSUE TYPE
    
    Docs Pull Request
    Feature Pull Request
    
    COMPONENT NAME
    ADDITIONAL INFORMATION
    Header cleanup based upon:
    https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
    
    Begin your Ansible module with #!/usr/bin/python - this “shebang” allows ansible_python_interpreter to work. Follow the shebang immediately with # -*- coding: utf-8 -*- to clarify that the file is UTF-8 encoded.
    
    and
    https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#copyright-and-license
    
    After the shebang and UTF-8 coding, add a copyright line with the original copyright holder and a license declaration. The license declaration should be ONLY one line, not the full GPL prefix.
    ...
    Additions to the module (for instance, rewrites) are not permitted to add additional copyright lines other than the default copyright statement if missing:
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@a4f20bf
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8869b4b View commit details
    Browse the repository at this point in the history
  31. Big Black PR (ansible-collections#1784)

    * Black prep
    
    * Black
    
    * changelog
    
    * Fix pylint unused-import in tests
    
    * Split SSM connection plugin changes
    
    * disable glue tests - bucket's missing
    
    * Disable s3_logging and s3_sync tests
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@2c4575c
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    42e32b0 View commit details
    Browse the repository at this point in the history
  32. Bulk migration to Python 3.6 f-strings (ansible-collections#1810)

    Bulk migration to Python 3.6 f-strings
    
    SUMMARY
    We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
    A combination of
    
    black --preview
    flynt
    some manual cleanup
    
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    plugins/
    tests/
    ADDITIONAL INFORMATION
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@de33821
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5ee4b65 View commit details
    Browse the repository at this point in the history
  33. Mass update of docs and tests (credentials/session tokens) (ansible-c…

    …ollections#1921)
    
    Mass update of docs and tests (credentials/session tokens)
    
    SUMMARY
    We had a cleanup of credentials/session parameters which included a batch of deprecations and renames.
    Ensure that all of our tests and docs are using the 'canonical' names
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    plugins/modules/batch_compute_environment.py
    plugins/modules/cloudformation_exports_info.py
    plugins/modules/ec2_vpc_vpn.py
    plugins/modules/elasticache.py
    plugins/modules/elasticache_parameter_group.py
    plugins/modules/elasticache_snapshot.py
    plugins/modules/ses_rule_set.py
    plugins/modules/sts_assume_role.py
    plugins/modules/sts_session_token.py
    tests/integration
    ADDITIONAL INFORMATION
    See also
    
    ansible-collections#1172
    ansible-collections#1714
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4a5b50e
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ed1e92f View commit details
    Browse the repository at this point in the history
  34. Apply isort and flynt (ansible-collections#1962)

    SUMMARY
    
    Apply isort - see also ansible-collections#1771
    Apply flynt - see also ansible-collections#1802
    
    ISSUE TYPE
    
        Feature Pull Request
    
    COMPONENT NAME
    
    ADDITIONAL INFORMATION
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@c0117b5
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a77eb0e View commit details
    Browse the repository at this point in the history
  35. ansible-lint (documentation) cleanup for plugins/ (ansible-collection…

    …s#2036)
    
    ansible-lint (documentation) cleanup for plugins/
    
    SUMMARY
    Fixes an array of ansible-lint failures in plugins/
    Adds ansible-lint plugins/ to tox -m lint
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    plugins/
    ADDITIONAL INFORMATION
    docs changes only (no changelog fragment needed)
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@6dd4a00
    tremble authored and abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a798231 View commit details
    Browse the repository at this point in the history
  36. ec2_vpc_vgw - fix call to parent static method in class VGWRetry (ans…

    …ible-collections#2140)
    
    SUMMARY
    
    When trying to create a VPN virtual gateway with a non-existent VPC id, module fails incorrectly with the following error
    \\"/tmp/ansible_community.aws.ec2_vpc_vgw_payload_t4kolii1/ansible_community.aws.ec2_vpc_vgw_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vgw.py\\", line 173, in found\\nTypeError: super(type, obj): obj must be an instance or subtype of type
    
    The fix consists in adding argument to super()
    
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    
    ec2_vpc_vgw
    
    Reviewed-by: Mark Chappell
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@87e2152
    abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    664664a View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    e0c9d78 View commit details
    Browse the repository at this point in the history
  38. Fix sanity issue

    abikouo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9beeab2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    678a053 View commit details
    Browse the repository at this point in the history