S3 Inventory #2074
S3 Inventory #2074
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 16s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 31s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 50s |
|
CI failed because of permissions, I have created a PR to add them - ansible/aws-ci-admin#6 |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 02s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 13s |
|
Build failed.
|
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 07s |
There was a problem hiding this comment.
Given that multiple inventory configurations can be applied to a bucket, I would suggest this be updated to allow providing a list of configuration dicts. The way this is written currently, it only allows one configuration and only compares the provided configuration to the first result from list_bucket_inventory_configurations, which seems like it could cause unexpected problems.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 36s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 11s |
There was a problem hiding this comment.
@abraverm Thank you for submitting these updates! In addition to the inline comments below, could you please add a changelog file and fix the linter errors by running the tox formatters with tox -m format? Let me know if you have questions.
|
recheck |
|
The tests are failing on things unrelated to this change: |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 01s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 24s |
There was a problem hiding this comment.
Thanks for taking the time to submit this PR.
One significant change needed here, please do not set default values for net-new options. Two reasons:
- This will cause the default behaviour to go from not touching the inventory configuration, to wiping the inventory configuration
- The S3 modules also support non-AWS S3-like APIs, by setting a default this instantly breaks any of them where the API doesn't support the new feature. This is a bit of a hassle, but is what it is.
abraverm
force-pushed
the
inventory
branch
2 times, most recently
from
1a7f384
to
9a7fa17
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 37s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 38s |
|
@hakbailey , Github says that you have requested changes, but I can't find any - what am I missing? |
|
@abraverm They're been "resolved" which is why they're not showing up. I'll request a fresh review from her. |
tremble
added
mergeit
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 33s |
softwarefactory-project-zuul
bot
merged commit c96d250
into
ansible-collections:main
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2273 🤖 @patchback |
SUMMARY Add S3 inventory support - https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-inventory.html ISSUE TYPE Feature Pull Request COMPONENT NAME S3 Bucket Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alexander Braverman Masis <[email protected]> Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit c96d250)
This is a backport of PR #2074 as merged into main (c96d250). SUMMARY Add S3 inventory support - https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-inventory.html ISSUE TYPE Feature Pull Request COMPONENT NAME S3 Bucket Reviewed-by: Mark Chappell
SUMMARY
Add S3 inventory support - https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-inventory.html
ISSUE TYPE
COMPONENT NAME
S3 Bucket