Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance: add AWSRetry.jittered_backoff on client.describe_instance_attribute #1650

Conversation

tchernomax
Copy link
Contributor

SUMMARY

try to fix InvalidInstanceID.NotFound

Could not describe attribute groupSet for instance i-…: An error occurred (InvalidInstanceID.NotFound) when calling the DescribeInstanceAttribute operation: The instance ID 'i-…' does not exist

The instance actually exists, it's just an API problem.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/11373217dc23472e80f3615f4657d6ce

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 5m 02s
✔️ integration-amazon.aws-1 SUCCESS in 22m 25s
✔️ integration-amazon.aws-2 SUCCESS in 16m 34s
✔️ integration-amazon.aws-3 SUCCESS in 13m 22s
✔️ integration-amazon.aws-4 SUCCESS in 11m 14s
✔️ integration-amazon.aws-5 SUCCESS in 11m 47s
✔️ integration-amazon.aws-6 SUCCESS in 11m 49s
✔️ integration-amazon.aws-7 SUCCESS in 11m 56s
✔️ integration-amazon.aws-8 SUCCESS in 11m 49s
✔️ integration-amazon.aws-9 SUCCESS in 7m 28s
✔️ integration-amazon.aws-10 SUCCESS in 12m 33s
✔️ integration-amazon.aws-11 SUCCESS in 11m 53s
✔️ integration-amazon.aws-12 SUCCESS in 7m 04s
✔️ integration-amazon.aws-13 SUCCESS in 9m 27s
✔️ integration-amazon.aws-14 SUCCESS in 12m 30s
✔️ integration-amazon.aws-15 SUCCESS in 6m 00s
✔️ integration-amazon.aws-16 SUCCESS in 7m 13s
✔️ integration-amazon.aws-17 SUCCESS in 8m 46s
Skipped 27 jobs

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 12, 2023
Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchernomax thank you for submitting this! The PR looks good but it needs a changelog fragment, would you be able to add that?

@tchernomax
Copy link
Contributor Author

@tchernomax thank you for submitting this! The PR looks good but it needs a changelog fragment, would you be able to add that?

done

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/650d1217e0574c1388d1337c7c2114fe

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-splitter SUCCESS in 6m 22s
integration-amazon.aws-1 RETRY_LIMIT in 5m 03s
integration-amazon.aws-2 RETRY_LIMIT in 1m 31s
integration-amazon.aws-3 RETRY_LIMIT in 1m 29s
integration-amazon.aws-4 RETRY_LIMIT in 1m 29s
integration-amazon.aws-5 RETRY_LIMIT in 1m 31s
integration-amazon.aws-6 RETRY_LIMIT in 5m 43s
integration-amazon.aws-7 RETRY_LIMIT in 1m 32s
integration-amazon.aws-8 RETRY_LIMIT in 1m 33s
integration-amazon.aws-9 RETRY_LIMIT in 5m 35s
integration-amazon.aws-10 RETRY_LIMIT in 1m 30s
integration-amazon.aws-11 RETRY_LIMIT in 4m 09s
integration-amazon.aws-12 RETRY_LIMIT in 1m 31s
integration-amazon.aws-13 RETRY_LIMIT in 3m 19s
integration-amazon.aws-14 RETRY_LIMIT in 1m 29s
integration-amazon.aws-15 RETRY_LIMIT in 1m 31s
integration-amazon.aws-16 RETRY_LIMIT in 3m 25s
integration-amazon.aws-17 RETRY_LIMIT in 5m 07s
integration-amazon.aws-18 RETRY_LIMIT in 5m 59s
Skipped 26 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5c4c07041eb14a8fa4580fa9452231cd

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 12m 18s
✔️ ansible-test-splitter SUCCESS in 5m 00s
✔️ integration-amazon.aws-1 SUCCESS in 27m 02s
✔️ integration-amazon.aws-2 SUCCESS in 17m 47s
✔️ integration-amazon.aws-3 SUCCESS in 11m 13s
✔️ integration-amazon.aws-4 SUCCESS in 12m 15s
✔️ integration-amazon.aws-5 SUCCESS in 8m 32s
✔️ integration-amazon.aws-6 SUCCESS in 8m 08s
✔️ integration-amazon.aws-7 SUCCESS in 12m 46s
✔️ integration-amazon.aws-8 SUCCESS in 8m 19s
✔️ integration-amazon.aws-9 SUCCESS in 12m 35s
✔️ integration-amazon.aws-10 SUCCESS in 13m 32s
✔️ integration-amazon.aws-11 SUCCESS in 12m 04s
✔️ integration-amazon.aws-12 SUCCESS in 11m 59s
✔️ integration-amazon.aws-13 SUCCESS in 8m 04s
✔️ integration-amazon.aws-14 SUCCESS in 9m 18s
✔️ integration-amazon.aws-15 SUCCESS in 12m 31s
✔️ integration-amazon.aws-16 SUCCESS in 9m 17s
integration-amazon.aws-17 RETRY_LIMIT in 1m 38s
✔️ integration-amazon.aws-18 SUCCESS in 6m 44s
Skipped 26 jobs

@alinabuzachis alinabuzachis added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Sep 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c45ad597be884fdea4b1c9b3aa70e780

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 12m 32s
✔️ ansible-test-splitter SUCCESS in 4m 55s
✔️ integration-amazon.aws-1 SUCCESS in 23m 23s
✔️ integration-amazon.aws-2 SUCCESS in 16m 34s
✔️ integration-amazon.aws-3 SUCCESS in 16m 42s
✔️ integration-amazon.aws-4 SUCCESS in 11m 03s
✔️ integration-amazon.aws-5 SUCCESS in 11m 15s
✔️ integration-amazon.aws-6 SUCCESS in 14m 16s
✔️ integration-amazon.aws-7 SUCCESS in 13m 54s
✔️ integration-amazon.aws-8 SUCCESS in 10m 46s
✔️ integration-amazon.aws-9 SUCCESS in 12m 47s
✔️ integration-amazon.aws-10 SUCCESS in 11m 29s
✔️ integration-amazon.aws-11 SUCCESS in 14m 23s
✔️ integration-amazon.aws-12 SUCCESS in 10m 52s
✔️ integration-amazon.aws-13 SUCCESS in 8m 06s
✔️ integration-amazon.aws-14 SUCCESS in 8m 47s
✔️ integration-amazon.aws-15 SUCCESS in 9m 52s
✔️ integration-amazon.aws-16 SUCCESS in 7m 46s
integration-amazon.aws-17 RETRY_LIMIT in 6m 56s
✔️ integration-amazon.aws-18 SUCCESS in 6m 10s
Skipped 26 jobs

@hakbailey
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/33107ecf27b34b0d94162aee1a64d7f8

✔️ ansible-galaxy-importer SUCCESS in 5m 01s
✔️ build-ansible-collection SUCCESS in 13m 24s
✔️ ansible-test-splitter SUCCESS in 6m 03s
integration-amazon.aws-1 FAILURE in 15m 43s
✔️ integration-amazon.aws-2 SUCCESS in 16m 08s
✔️ integration-amazon.aws-3 SUCCESS in 12m 50s
✔️ integration-amazon.aws-4 SUCCESS in 13m 57s
✔️ integration-amazon.aws-5 SUCCESS in 9m 14s
✔️ integration-amazon.aws-6 SUCCESS in 6m 53s
✔️ integration-amazon.aws-7 SUCCESS in 7m 31s
✔️ integration-amazon.aws-8 SUCCESS in 9m 57s
✔️ integration-amazon.aws-9 SUCCESS in 7m 12s
✔️ integration-amazon.aws-10 SUCCESS in 14m 59s
✔️ integration-amazon.aws-11 SUCCESS in 15m 12s
✔️ integration-amazon.aws-12 SUCCESS in 12m 48s
✔️ integration-amazon.aws-13 SUCCESS in 9m 41s
✔️ integration-amazon.aws-14 SUCCESS in 10m 42s
✔️ integration-amazon.aws-15 SUCCESS in 9m 06s
✔️ integration-amazon.aws-16 SUCCESS in 8m 34s
✔️ integration-amazon.aws-17 SUCCESS in 9m 01s
✔️ integration-amazon.aws-18 SUCCESS in 6m 53s
Skipped 26 jobs

@tchernomax
Copy link
Contributor Author

any news ?
Is there something I need to do to make this PR merged ?

@gravesm
Copy link
Member

gravesm commented Sep 18, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6a4d1ce970854e1e9ce0521f46f718cc

✔️ ansible-galaxy-importer SUCCESS in 5m 00s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 4m 40s
✔️ integration-amazon.aws-1 SUCCESS in 27m 16s
✔️ integration-amazon.aws-2 SUCCESS in 18m 08s
✔️ integration-amazon.aws-3 SUCCESS in 13m 42s
✔️ integration-amazon.aws-4 SUCCESS in 11m 57s
✔️ integration-amazon.aws-5 SUCCESS in 12m 56s
integration-amazon.aws-6 RETRY_LIMIT in 1m 42s
✔️ integration-amazon.aws-7 SUCCESS in 12m 36s
✔️ integration-amazon.aws-8 SUCCESS in 11m 40s
✔️ integration-amazon.aws-9 SUCCESS in 11m 53s
✔️ integration-amazon.aws-10 SUCCESS in 12m 10s
✔️ integration-amazon.aws-11 SUCCESS in 12m 26s
✔️ integration-amazon.aws-12 SUCCESS in 12m 54s
✔️ integration-amazon.aws-13 SUCCESS in 8m 18s
✔️ integration-amazon.aws-14 SUCCESS in 9m 52s
✔️ integration-amazon.aws-15 SUCCESS in 13m 42s
✔️ integration-amazon.aws-16 SUCCESS in 8m 20s
✔️ integration-amazon.aws-17 SUCCESS in 8m 11s
✔️ integration-amazon.aws-18 SUCCESS in 7m 16s
Skipped 26 jobs

@tchernomax
Copy link
Contributor Author

@gravesm it seems it fail at a different test at each run.

plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eba1c8210e8d44d0b01586015bb0c54f

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 13m 12s
✔️ ansible-test-splitter SUCCESS in 4m 54s
✔️ integration-amazon.aws-1 SUCCESS in 25m 52s
✔️ integration-amazon.aws-2 SUCCESS in 17m 41s
✔️ integration-amazon.aws-3 SUCCESS in 11m 23s
✔️ integration-amazon.aws-4 SUCCESS in 8m 36s
✔️ integration-amazon.aws-5 SUCCESS in 8m 23s
✔️ integration-amazon.aws-6 SUCCESS in 12m 30s
✔️ integration-amazon.aws-7 SUCCESS in 12m 26s
✔️ integration-amazon.aws-8 SUCCESS in 13m 00s
✔️ integration-amazon.aws-9 SUCCESS in 8m 58s
✔️ integration-amazon.aws-10 SUCCESS in 11m 44s
✔️ integration-amazon.aws-11 SUCCESS in 13m 57s
✔️ integration-amazon.aws-12 SUCCESS in 14m 26s
✔️ integration-amazon.aws-13 SUCCESS in 8m 52s
✔️ integration-amazon.aws-14 SUCCESS in 13m 57s
✔️ integration-amazon.aws-15 SUCCESS in 10m 56s
✔️ integration-amazon.aws-16 SUCCESS in 7m 37s
✔️ integration-amazon.aws-17 SUCCESS in 8m 19s
✔️ integration-amazon.aws-18 SUCCESS in 13m 11s
Skipped 26 jobs

@tremble tremble removed the backport-5 PR should be backported to the stable-5 branch label Oct 20, 2023
@tremble
Copy link
Contributor

tremble commented Oct 20, 2023

Thanks for submitting this PR. I'm sorry it's taken so long to get this merged.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5eb790cf951f4d38b8b7cee765263963

✔️ ansible-galaxy-importer SUCCESS in 12m 11s
✔️ build-ansible-collection SUCCESS in 13m 29s
✔️ ansible-test-splitter SUCCESS in 4m 47s
✔️ integration-amazon.aws-1 SUCCESS in 26m 17s
✔️ integration-amazon.aws-2 SUCCESS in 18m 18s
integration-amazon.aws-3 RETRY_LIMIT in 1m 47s
✔️ integration-amazon.aws-4 SUCCESS in 12m 05s
✔️ integration-amazon.aws-5 SUCCESS in 17m 34s
✔️ integration-amazon.aws-6 SUCCESS in 11m 29s
✔️ integration-amazon.aws-7 SUCCESS in 10m 24s
✔️ integration-amazon.aws-8 SUCCESS in 12m 24s
integration-amazon.aws-9 RETRY_LIMIT in 1m 44s
✔️ integration-amazon.aws-10 SUCCESS in 12m 36s
✔️ integration-amazon.aws-11 SUCCESS in 23m 57s
✔️ integration-amazon.aws-12 SUCCESS in 11m 18s
✔️ integration-amazon.aws-13 SUCCESS in 11m 05s
✔️ integration-amazon.aws-14 SUCCESS in 12m 45s
✔️ integration-amazon.aws-15 SUCCESS in 10m 27s
integration-amazon.aws-16 RETRY_LIMIT in 1m 46s
✔️ integration-amazon.aws-17 SUCCESS in 11m 54s
✔️ integration-amazon.aws-18 SUCCESS in 9m 58s
Skipped 26 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/08a3ada802114777a380af31be7e845b

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 13m 31s
✔️ ansible-test-splitter SUCCESS in 5m 03s
✔️ integration-amazon.aws-1 SUCCESS in 27m 12s
✔️ integration-amazon.aws-2 SUCCESS in 19m 11s
✔️ integration-amazon.aws-3 SUCCESS in 19m 23s
✔️ integration-amazon.aws-4 SUCCESS in 13m 55s
✔️ integration-amazon.aws-5 SUCCESS in 8m 37s
✔️ integration-amazon.aws-6 SUCCESS in 11m 28s
✔️ integration-amazon.aws-7 SUCCESS in 13m 28s
✔️ integration-amazon.aws-8 SUCCESS in 8m 51s
✔️ integration-amazon.aws-9 SUCCESS in 12m 01s
✔️ integration-amazon.aws-10 SUCCESS in 15m 03s
✔️ integration-amazon.aws-11 SUCCESS in 12m 26s
✔️ integration-amazon.aws-12 SUCCESS in 11m 28s
✔️ integration-amazon.aws-13 SUCCESS in 9m 23s
✔️ integration-amazon.aws-14 SUCCESS in 13m 38s
✔️ integration-amazon.aws-15 SUCCESS in 10m 54s
✔️ integration-amazon.aws-16 SUCCESS in 10m 12s
✔️ integration-amazon.aws-17 SUCCESS in 10m 24s
✔️ integration-amazon.aws-18 SUCCESS in 7m 46s
Skipped 26 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ead8302 into ansible-collections:main Oct 20, 2023
35 of 65 checks passed
@patchback
Copy link

patchback bot commented Oct 20, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/ead83029016663992ca163828402f59e7bb749a6/pr-1650

Backported as #1817

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 20, 2023
…ce_attribute (#1650)

ec2_instance: add AWSRetry.jittered_backoff on client.describe_instance_attribute

SUMMARY
try to fix InvalidInstanceID.NotFound

Could not describe attribute groupSet for instance i-…: An error occurred (InvalidInstanceID.NotFound) when calling the DescribeInstanceAttribute operation: The instance ID 'i-…' does not exist

The instance actually exists, it's just an API problem.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Alina Buzachis
Reviewed-by: tchernomax
Reviewed-by: Mark Chappell
(cherry picked from commit ead8302)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 20, 2023
…ce_attribute (#1650) (#1817)

[PR #1650/ead83029 backport][stable-6] ec2_instance: add AWSRetry.jittered_backoff on client.describe_instance_attribute

This is a backport of PR #1650 as merged into main (ead8302).
SUMMARY
try to fix InvalidInstanceID.NotFound

Could not describe attribute groupSet for instance i-…: An error occurred (InvalidInstanceID.NotFound) when calling the DescribeInstanceAttribute operation: The instance ID 'i-…' does not exist

The instance actually exists, it's just an API problem.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants