[PR #1589/614b792b backport][stable-6] cloudwatchevent_rule should return false when there is no change done to the rule #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
… to the rule (#1589) cloudwatchevent_rule should return false when there is no change done to the rule SUMMARY Fixes #1080 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/cloudwatchevent_rule.py ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Mark Chappell Reviewed-by: Jill R Reviewed-by: Alina Buzachis (cherry picked from commit 614b792)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 04s |
alinabuzachis
approved these changes
Jul 4, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 08s |
softwarefactory-project-zuul
bot
merged commit 4adb1b6
into
stable-6
36 of 38 checks passed
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-6/614b792be81a8a64c8c955093c853733ca1f57c3/pr-1589
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ecs_cluster capacity provider strategy SUMMARY Fixes ansible-collections#770 - Add AWS ECS_Cluster Capacity Provider Strategy Support ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_cluster ADDITIONAL INFORMATION When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user. Given playbook task: - name: Create an ECS Cluster with Capacity Providers ecs_cluster: name: default state: present capacity_providers: - FARGATE - FARGATE_SPOT capacity_provider_strategy: - capacity_provider: FARGATE base: 1 weight: 1 - capacity_provider: FARGATE_SPOT weight: 100 Previously would throw "Unsupported parameter" and no other parameter exists to expose these features. Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Justin McCormick <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ecs_cluster: add default value to doc SUMMARY missing default value in the docs section of ansible-collections#1640 not released yet. ISSUE TYPE Docs Pull Request COMPONENT NAME ecs_cluster Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ecs_cluster capacity provider strategy SUMMARY Fixes ansible-collections#770 - Add AWS ECS_Cluster Capacity Provider Strategy Support ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_cluster ADDITIONAL INFORMATION When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user. Given playbook task: - name: Create an ECS Cluster with Capacity Providers ecs_cluster: name: default state: present capacity_providers: - FARGATE - FARGATE_SPOT capacity_provider_strategy: - capacity_provider: FARGATE base: 1 weight: 1 - capacity_provider: FARGATE_SPOT weight: 100 Previously would throw "Unsupported parameter" and no other parameter exists to expose these features. Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Justin McCormick <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ecs_cluster: add default value to doc SUMMARY missing default value in the docs section of ansible-collections#1640 not released yet. ISSUE TYPE Docs Pull Request COMPONENT NAME ecs_cluster Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
ecs_cluster capacity provider strategy SUMMARY Fixes ansible-collections#770 - Add AWS ECS_Cluster Capacity Provider Strategy Support ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_cluster ADDITIONAL INFORMATION When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user. Given playbook task: - name: Create an ECS Cluster with Capacity Providers ecs_cluster: name: default state: present capacity_providers: - FARGATE - FARGATE_SPOT capacity_provider_strategy: - capacity_provider: FARGATE base: 1 weight: 1 - capacity_provider: FARGATE_SPOT weight: 100 Previously would throw "Unsupported parameter" and no other parameter exists to expose these features. Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Justin McCormick <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
ecs_cluster: add default value to doc SUMMARY missing default value in the docs section of ansible-collections#1640 not released yet. ISSUE TYPE Docs Pull Request COMPONENT NAME ecs_cluster Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1589 as merged into main (614b792).
SUMMARY
Fixes #1080
ISSUE TYPE
COMPONENT NAME
plugins/modules/cloudwatchevent_rule.py
ADDITIONAL INFORMATION