Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1633/cfeffe66 backport][stable-6] Document and validate backup_selection conditions suboptions #1638

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 4, 2023

This is a backport of PR #1633 as merged into main (cfeffe6).

SUMMARY

Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613

Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

backup_selection
module_utils.backup

ADDITIONAL INFORMATION

See #1613 for detailed description of related issue.

Document and validate backup_selection conditions suboptions

SUMMARY
Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613
Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
backup_selection
module_utils.backup
ADDITIONAL INFORMATION
See #1613 for detailed description of related issue.

Reviewed-by: Jill R
Reviewed-by: Alina Buzachis
(cherry picked from commit cfeffe6)
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/beebbe68b0a542e09b7433d19fcf1974

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 13m 02s
✔️ ansible-test-splitter SUCCESS in 5m 26s
✔️ integration-amazon.aws-1 SUCCESS in 6m 06s
✔️ integration-amazon.aws-2 SUCCESS in 8m 13s
✔️ integration-amazon.aws-3 SUCCESS in 5m 50s
✔️ integration-amazon.aws-4 SUCCESS in 7m 54s
Skipped 40 jobs

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/9ec1e45347a841eebd36a5a5ff395884

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 14m 01s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-amazon.aws-1 SUCCESS in 6m 10s
✔️ integration-amazon.aws-2 SUCCESS in 5m 51s
✔️ integration-amazon.aws-3 SUCCESS in 6m 08s
✔️ integration-amazon.aws-4 SUCCESS in 5m 55s
Skipped 40 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e4c5ba1 into stable-6 Jul 4, 2023
36 of 38 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/cfeffe665a55e24426bede38afab01c1dfa0cd90/pr-1633 branch July 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants