Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon.aws.elb_classic_lb does not support deletion_protection argument #2142

Closed
1 task done
stefanhorning opened this issue Jun 24, 2024 · 2 comments
Closed
1 task done
Labels

Comments

@stefanhorning
Copy link
Contributor

Summary

Unlike the other ELB modules the elb_classic_lb module does not support the deletion_protection argument.
This is somewhat inconsistent as this is a flag supported by all ELB types on AWS. So it would be nice to add it to the Ansible module too.
So one could add this line to all elb modules:
deletion_protection: true

Thank you for your consideration.

Issue Type

Feature Idea

Component Name

amazon.aws.elb_classic_lb

Additional Information

- name: Example ELB task
  amazon.aws.elb_classic_lb:
    name: 'my-classic-elb'
    scheme: internal
    security_group_ids: vpc-abc123
    listeners: [...]
    deletion_protection: true
    state: present

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@stefanhorning
Copy link
Contributor Author

stefanhorning commented Jun 24, 2024

Ok, rechecking the AWS Console, it might be that deletion protection might not be available on those ELBs on AWS side. was just confused by the Boto3 docs which make it appear like this is possible for all ELB types.

@hakbailey hakbailey added needs_verified Some one might want to take a look at this and reproduce it to confirm and removed needs_triage labels Jun 25, 2024
@mandar242
Copy link
Contributor

Hi @stefanhorning, thank you for reporting. Looking at the aws documentation, I think classic load balancers might not support deletion_protection attribute.
https://docs.aws.amazon.com/cli/latest/reference/elb/modify-load-balancer-attributes.html

Whereas Application, Network, Gateway Load balancers do support it.
https://docs.aws.amazon.com/cli/latest/reference/elbv2/modify-load-balancer-attributes.html

Please feel free to reopen the issue if required. Thanks!

@mandar242 mandar242 added jira and removed needs_verified Some one might want to take a look at this and reproduce it to confirm labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants