Skip to content

Commit

Permalink
Varous fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Alina Buzachis <[email protected]>
  • Loading branch information
alinabuzachis committed Jul 5, 2023
1 parent 045bc77 commit feedfb5
Show file tree
Hide file tree
Showing 12 changed files with 19 additions and 54 deletions.
3 changes: 0 additions & 3 deletions tests/unit/module_utils/cloud/test_cloud_retry.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

import random
from datetime import datetime
import pytest
Expand Down
8 changes: 3 additions & 5 deletions tests/unit/module_utils/cloud/test_decorator_generation.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

import pytest
import sys

from unittest.mock import MagicMock
from unittest.mock import sentinel

from ansible_collections.amazon.aws.plugins.module_utils.cloud import CloudRetry
from ansible_collections.amazon.aws.plugins.module_utils.cloud import BackoffIterator
from ansible_collections.amazon.aws.tests.unit.compat.mock import MagicMock
from ansible_collections.amazon.aws.tests.unit.compat.mock import sentinel

if sys.version_info < (3, 8):
pytest.skip("accessing call_args.kwargs by keyword (instead of index) was introduced in Python 3.8", allow_module_level=True)
Expand Down
8 changes: 3 additions & 5 deletions tests/unit/module_utils/cloud/test_retry_func.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,13 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

import pytest
import sys

from unittest.mock import Mock
from unittest.mock import sentinel

import ansible_collections.amazon.aws.plugins.module_utils.cloud as cloud_utils
from ansible_collections.amazon.aws.tests.unit.compat.mock import Mock
from ansible_collections.amazon.aws.tests.unit.compat.mock import sentinel

if sys.version_info < (3, 8):
pytest.skip("accessing call_args.kwargs by keyword (instead of index) was introduced in Python 3.8", allow_module_level=True)
Expand Down
5 changes: 2 additions & 3 deletions tests/unit/module_utils/test_elbv2.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from unittest.mock import MagicMock

from ansible_collections.amazon.aws.plugins.module_utils import elbv2
from ansible_collections.amazon.aws.tests.unit.compat.mock import MagicMock


one_action = [
{
Expand Down
5 changes: 1 addition & 4 deletions tests/unit/module_utils/test_iam.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

import pytest

try:
Expand All @@ -15,7 +12,7 @@
# Handled by HAS_BOTO3
pass

from ansible_collections.amazon.aws.tests.unit.compat.mock import MagicMock
from unittest.mock import MagicMock

import ansible_collections.amazon.aws.plugins.module_utils.iam as utils_iam
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import HAS_BOTO3
Expand Down
9 changes: 1 addition & 8 deletions tests/unit/module_utils/test_rds.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,8 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import absolute_import, division, print_function
__metaclass__ = type

import sys
import pytest

if sys.version_info < (3, 7):
pytest.skip("contextlib.nullcontext was introduced in Python 3.7", allow_module_level=True)

from contextlib import nullcontext

try:
Expand All @@ -20,7 +13,7 @@
# Handled by HAS_BOTO3
pass

from ansible_collections.amazon.aws.tests.unit.compat.mock import MagicMock
from unittest.mock import MagicMock

from ansible_collections.amazon.aws.plugins.module_utils import rds
from ansible_collections.amazon.aws.plugins.module_utils.botocore import HAS_BOTO3
Expand Down
5 changes: 1 addition & 4 deletions tests/unit/module_utils/test_s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
from unittest.mock import MagicMock

__metaclass__ = type

from ansible_collections.amazon.aws.tests.unit.compat.mock import MagicMock
from ansible_collections.amazon.aws.plugins.module_utils import s3
from ansible.module_utils.basic import AnsibleModule

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from unittest.mock import sentinel

from ansible_collections.amazon.aws.plugins.module_utils.transformation import map_complex_type

from ansible_collections.amazon.aws.tests.unit.compat.mock import sentinel


def test_map_complex_type_over_dict():
type_map = {'minimum_healthy_percent': 'int', 'maximum_percent': 'int'}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

import pytest

from ansible_collections.amazon.aws.tests.unit.compat.mock import sentinel
from unittest.mock import sentinel
import ansible_collections.amazon.aws.plugins.modules.ec2_instance as ec2_instance_module


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,10 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

import pytest
import sys

from ansible_collections.amazon.aws.tests.unit.compat.mock import MagicMock
from ansible_collections.amazon.aws.tests.unit.compat.mock import sentinel
from unittest.mock import MagicMock
from unittest.mock import sentinel
import ansible_collections.amazon.aws.plugins.modules.ec2_instance as ec2_instance_module
import ansible_collections.amazon.aws.plugins.module_utils.arn as utils_arn
from ansible_collections.amazon.aws.plugins.module_utils.botocore import HAS_BOTO3
Expand Down
4 changes: 1 addition & 3 deletions tests/unit/plugins/modules/test_ec2_vpc_dhcp_option.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
# This file is part of Ansible
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from unittest.mock import patch

# Magic... Incorrectly identified by pylint as unused
from ansible_collections.amazon.aws.tests.unit.utils.amazon_placebo_fixtures import placeboify # pylint: disable=unused-import
from ansible_collections.amazon.aws.tests.unit.compat.mock import patch

from ansible_collections.amazon.aws.plugins.modules import ec2_vpc_dhcp_option as dhcp_module
from ansible_collections.amazon.aws.tests.unit.plugins.modules.utils import ModuleTestCase
Expand Down
7 changes: 3 additions & 4 deletions tests/unit/plugins/modules/utils.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

import json

from ansible_collections.amazon.aws.tests.unit.compat import unittest
from ansible_collections.amazon.aws.tests.unit.compat.mock import patch
import unittest
from unittest.mock import patch
from ansible.module_utils import basic
from ansible.module_utils._text import to_bytes

Expand Down

0 comments on commit feedfb5

Please sign in to comment.