Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter statistics deck switcher search form programmatic usage to match "statisticsSearchText" element id vs "first text box" #17075

Open
mikehardy opened this issue Sep 16, 2024 · 1 comment
Labels
Anki Ecosystem Compatibility Blocked by dependency Currently blocked by some other dependent / related change Good First Issue!

Comments

@mikehardy
Copy link
Member

mikehardy commented Sep 16, 2024

Examine how the statistics deck switcher uses the upstream Svelte form to programmatically switch decks
Note that if upstream moves the element around, it will break since we match "first text box" instead of something unambiguous

Previously the text box had no id so there was no unambiguous way to match it, but a change was recently merged that gives it the id "statisticsSearchText" and we should alter code here to use that id

This will remain "blocked by dependency" until Anki-Android-Backend is updated with whatever the first release of anki upstream is that contains this commit:

ankitects/anki@1b7123a

...once we have the backend updated to use a version of anki with the text box id and we have adopted it here, this is good to go.

It is marked as a "good first issue" because it really should be - however it will be blocked for a while and you'll need to check if it is unblocked before even attempting to work on it. So be careful with that check before spending any time, thanks

@mikehardy mikehardy added Bug Needs Triage Anki Ecosystem Compatibility Blocked by dependency Currently blocked by some other dependent / related change and removed Bug Needs Triage labels Sep 16, 2024
@mikehardy mikehardy changed the title Alter upstream search form programmatic usage to match future element id vs "first text box" Alter statistics deck switcher search form programmatic usage to match "statisticsSearchText" element id vs "first text box" Sep 20, 2024
@Aditya13s
Copy link
Contributor

I will work on it when it gets unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anki Ecosystem Compatibility Blocked by dependency Currently blocked by some other dependent / related change Good First Issue!
Projects
None yet
Development

No branches or pull requests

2 participants