Anti-pattern: (JS-0323) Fix #2039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maleksal
requested changes
Feb 4, 2025
There was a problem hiding this comment.
@davido-noowin, please correct your package.json files.
- Remove the dependencies installed in the root
package.jsonand install each one in its correspondingbackendorfrontenddirectory. - Remove this part from package.json
"leadminer": "file:.." - Run
npm run prettier:fixin frontend to fix formatting andnpm run lint:fixto fix linting
|
You’re still facing issues with package.json files. Here’s a quick fix:
This will validate your unit tests. If everything works fine, push your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2030. Originally, leadminer/backend/src/utils/helpers/validation.ts had code that could not interact with the type change from
anytounknown, but changes have been made. There is another if statement to check for thestringtype, as the original function only contained a check for typestring[].A unit test file has been made for this function calledvalidation.test.ts