Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor email status clients to support rate-limiter options #2021

Open
3 tasks
maleksal opened this issue Jan 31, 2025 · 0 comments
Open
3 tasks

Refactor email status clients to support rate-limiter options #2021

maleksal opened this issue Jan 31, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@maleksal
Copy link
Collaborator

maleksal commented Jan 31, 2025

Overview

Currently, ZerobounceClient and MailercheckClient do not support configurable rate-limiter options. This makes it difficult to control API request rates and properly test rate-limiting behavior.

Tasks

  • Ensure both clients have configurable rate-limiter options via constructor.
  • Use environment variables for rate-limiter settings.
  • Add unit tests to validate rate-limiter functionality.

Guidelines

  • Create a separate PR for each sub-issue.
  • In the PR description, reference the issue to close it automatically when your PR is merged. Read more:
    Resolves #<issue_number>
    
@maleksal maleksal added the good first issue Good for newcomers label Jan 31, 2025
@maleksal maleksal changed the title test rate limiting for zerobounce mailercheck, zerobounce rate-limiter unittests Jan 31, 2025
@maleksal maleksal changed the title mailercheck, zerobounce rate-limiter unittests Refactor Email Status Clients to Support Rate-Limiter Options Jan 31, 2025
@maleksal maleksal changed the title Refactor Email Status Clients to Support Rate-Limiter Options Refactor email status clients to support rate-limiter options Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant