Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goog.require rewriter doesn't work for dynamic imports #981

Open
rkirov opened this issue Feb 2, 2019 · 0 comments
Open

Goog.require rewriter doesn't work for dynamic imports #981

rkirov opened this issue Feb 2, 2019 · 0 comments

Comments

@rkirov
Copy link
Contributor

rkirov commented Feb 2, 2019

Since we are moving in the direction of supporting tsickle prod output being consumed by nodejs programs, we need to support the goog.require rewrites even for dynamic import (which are technically not supported by the closure's optimizer).

For example, the emit of this code should be
https://github.com/bazelbuild/rules_typescript/blob/master/internal/tsc_wrapped/tsc_wrapped.ts#L285

Or maybe tsickle should be rejecting dynamic imports, in any case it should not be emitting broken requires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant