-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No externs are generated for re-exported namespace #1203
Comments
(Edit: deleted comment above that wasn't about this specific bug.) |
In general, I believe tsickle doesn't support imports or exports within externs at all. I think there's a more general bug in the tracker that is about this problem, that this might be considered a dup or a subtask of. We don't really have a good conception of how to even represent this, given that externs files themselves can't have import/exports. |
Isn't a module
Module |
We definitely would like this to work, we just haven't had time for it. I think you're right that hiding things on a namespace works for a single file, but I'm not sure whether all the various other interactions do the right thing with it. |
(Part of the reason we haven't worked on this much is that we don't have a good model for using third-party dependencies in JSCompiler even when there is no TS involved.) |
Huh, I thought it is already doing the right thing most of time. If you have some particular concerns I'd like to know, I am willing to work on this issue and provide a PR. |
Sure, send a PR for this if you have a fix. |
As I understand tsickle does not support generating externs from
export * from '...'
syntax (which I couldn't find a tracking issue), but it seems that it does not support externs generation for the following situation as well:The text was updated successfully, but these errors were encountered: