Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building scss with sass-embedded #29319

Open
mattlewis92 opened this issue Jan 10, 2025 · 1 comment
Open

Support building scss with sass-embedded #29319

mattlewis92 opened this issue Jan 10, 2025 · 1 comment
Labels
angular/build:application area: @angular/build feature: in backlog Feature request for which voting has completed and is now in the backlog feature Issue that requests a new feature needs: investigation Requires some digging to determine if action is needed

Comments

@mattlewis92
Copy link
Contributor

Command

build, serve

Description

Over the last year the sass-embedded package has become really stable and is much faster than the sass package used by the angular CLI for building scss files today (on our enormous application, we were able to compile all our scss files about 30s faster using sass-embedded)

Vite also recently added support: vitejs/vite#17754

Describe the solution you'd like

If the sass-embedded embedded package is installed in the root package.json, the angular CLI would use that to compile all scss files instead of the sass package.

Describe alternatives you've considered

No response

@alan-agius4
Copy link
Collaborator

This is definitely worth revisiting. When we ran benchmarks previously, we noticed it was significantly faster with large SCSS files. However, for smaller stylesheets, the overhead introduced by spawning an additional child process for each sheet caused compilation to take longer—especially for component styles, which are typically smaller.

We should give this another go and run benchmarks again.

@alan-agius4 alan-agius4 added feature Issue that requests a new feature needs: investigation Requires some digging to determine if action is needed angular/build:application area: @angular/build feature: in backlog Feature request for which voting has completed and is now in the backlog labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular/build:application area: @angular/build feature: in backlog Feature request for which voting has completed and is now in the backlog feature Issue that requests a new feature needs: investigation Requires some digging to determine if action is needed
Projects
None yet
Development

No branches or pull requests

2 participants