From b5e485b996da7dabfc094f7747a4c5841656b2e1 Mon Sep 17 00:00:00 2001 From: Chris <37954566+codingnuclei@users.noreply.github.com> Date: Mon, 24 Mar 2025 14:29:17 +0000 Subject: [PATCH] fix(soba): correctly track billboard group rotation --- libs/soba/abstractions/src/lib/billboard.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/soba/abstractions/src/lib/billboard.ts b/libs/soba/abstractions/src/lib/billboard.ts index d2ba5083..b2940aff 100644 --- a/libs/soba/abstractions/src/lib/billboard.ts +++ b/libs/soba/abstractions/src/lib/billboard.ts @@ -57,7 +57,7 @@ export class NgtsBillboard { if (!follow || !group) return; // save previous rotation in case we're locking an axis - const prevRotation = group.rotation.clone(); + const prevRotation = inner.rotation.clone(); // always face the camera group.updateMatrix(); @@ -66,9 +66,9 @@ export class NgtsBillboard { camera.getWorldQuaternion(inner.quaternion).premultiply(q.invert()); // readjust any axis that is locked - if (lockX) group.rotation.x = prevRotation.x; - if (lockY) group.rotation.y = prevRotation.y; - if (lockZ) group.rotation.z = prevRotation.z; + if (lockX) inner.rotation.x = prevRotation.x; + if (lockY) inner.rotation.y = prevRotation.y; + if (lockZ) inner.rotation.z = prevRotation.z; }); } }