Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack: sass-loader doesn't use ExtractTextPlugin and has redundant include #2509

Open
1 task done
nstuyvesant opened this issue Feb 27, 2017 · 0 comments
Open
1 task done

Comments

@nstuyvesant
Copy link
Contributor

nstuyvesant commented Feb 27, 2017

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.3
Node 7.6.0
npm 4.3.0
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB PostgreSQL/Sequelize
Auth Y

What I was trying to do:
Scaffold out a project that uses only Sass for CSS.

What I expected to happen:
When doing a gulp build, expected a separate CSS file to be generated by Webpack so that the CSS could be loaded asynchronously.

What happened:
Sass was embedded in JS files.

Why it happened:
The file, templates/app/webpack.make.js, only uses ExtractTextPlugin for CSS and not Sass.

Also, this line seems to be redundant because this line is in templates/app/client/app/app(sass).scss. If the sass-loader starts with the generated app.scss, it should get everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant