Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTE on gulp-if version for adf-widgets #7

Open
bwinchester opened this issue Feb 9, 2017 · 0 comments
Open

NOTE on gulp-if version for adf-widgets #7

bwinchester opened this issue Feb 9, 2017 · 0 comments

Comments

@bwinchester
Copy link

Just a note: I used the normal commands to install the generator

npm install -g generator-adf-widget

And it seems to default to an older version that has a dependency on the gulp-if version that is buggy and will break builds. Took a while to figure out what exactly was broken. Then I realized you have a git tag #3.3 which points to a very recent version of gulp-if. I typed yo, and went through the process of telling it to upgrade this generator through their menu and it told me it was now at [email protected].

So for anyone searching, upgrade this generator if it defaults to an old one and your JS is being put in angular $templateCache.

Also, if anyone downloads copies of the adf-widgets, such as iframe or clock, their package.json files also point to the buggy gulp-if @ ^1.2.5. So if you try to fork those, change the gulp-if dependency to something after 2.x so the build of the widget works correctly.

@bwinchester bwinchester changed the title Bump gulp-if version NOTE on gulp-if version for adf-widgets Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant