Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tab+keyboard accesibility #177

Open
2 of 4 tasks
angrykoala opened this issue Oct 9, 2017 · 5 comments
Open
2 of 4 tasks

Improve tab+keyboard accesibility #177

angrykoala opened this issue Oct 9, 2017 · 5 comments

Comments

@angrykoala
Copy link
Owner

angrykoala commented Oct 9, 2017

The main features on Gaucho should be accessible using tab to navigate around the buttons. The style of the highlight should be in accordance with the rest of the application (and taking in account is a Desktop app)

Some things to consider:

  • By default, no button should be highlighted, and they should not highlight when using the mouse, only when tabbing.
  • When tabbing through a suite, the task should be selected, to show the logs/edit
  • When the command input is selected in edit mode, the tab won't jump to the next element, this is a feature explicitly added, but, unless a solution is found, should be removed to improve accessibility.
  • Some default highlights are disabled in the css as they didn't work properly, enable to start working on this

This is a long issue that may be split in several tasks if needed

@PhilTerz
Copy link
Contributor

PhilTerz commented Oct 9, 2017

This is a good list. The command feature preventing tabbing in edit mode is a somewhat common issue I've seen so there may be a fix... I'll try to look into it

@angrykoala
Copy link
Owner Author

angrykoala commented Oct 9, 2017

Thanks @PhilTerz Solving that thing in particular should be trivial, as the implementation explicitly changes that by capturing the tab event (so, basically, just removing that code).

@PhilTerz
Copy link
Contributor

PhilTerz commented Oct 9, 2017

Okay perfect, will do that

@PhilTerz
Copy link
Contributor

Submitted a PR for the command tab issue. Was playing around to see the current tab work for the rest of the app. Lots more there so I will definitely look into that this week!

@angrykoala angrykoala modified the milestones: 0.6, 0.7 Jun 13, 2018
@angrykoala angrykoala removed this from the 0.7 milestone May 29, 2019
@angrykoala angrykoala added this to the 1.0 milestone Sep 6, 2019
@angrykoala
Copy link
Owner Author

This issue has been stale from some time, the basic interactions with Gaucho have changed a lot, as now (to mimic a desktop app) no highlight (except minor visual changes) is used for mouse.

The focus of this task should be in making gaucho work with just keyboard (using tabs+key shortcuts) when possible. Other accessibility improvements will have their own issue assigned

@angrykoala angrykoala changed the title Improve accesibility Improve tab+keyboard accesibility Jan 22, 2021
@angrykoala angrykoala removed this from the 1.0 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants