Skip to content

Commit 5379b56

Browse files
committed
Revert "Merge PR FoundationAgents#1060"
This reverts commit ecbfa94, reversing changes made to 8593116.
1 parent ecbfa94 commit 5379b56

File tree

4 files changed

+7
-35
lines changed

4 files changed

+7
-35
lines changed

app/bedrock.py

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,10 @@ def model_dump(self, *args, **kwargs):
3636

3737
# Main client class for interacting with Amazon Bedrock
3838
class BedrockClient:
39-
def __init__(
40-
self,
41-
aws_access_key_id: str | None = None,
42-
aws_secret_access_key: str | None = None,
43-
aws_region_name: str | None = None,
44-
):
39+
def __init__(self):
4540
# Initialize Bedrock client, you need to configure AWS env first
4641
try:
47-
self.client = boto3.client(
48-
"bedrock-runtime",
49-
aws_access_key_id=aws_access_key_id,
50-
aws_secret_access_key=aws_secret_access_key,
51-
region_name=aws_region_name,
52-
)
42+
self.client = boto3.client("bedrock-runtime")
5343
self.chat = Chat(self.client)
5444
except Exception as e:
5545
print(f"Error initializing Bedrock client: {e}")
@@ -183,9 +173,9 @@ def _convert_bedrock_response_to_openai_format(self, bedrock_response):
183173
"role": bedrock_response.get("output", {})
184174
.get("message", {})
185175
.get("role", "assistant"),
186-
"tool_calls": (
187-
openai_tool_calls if openai_tool_calls != [] else None
188-
),
176+
"tool_calls": openai_tool_calls
177+
if openai_tool_calls != []
178+
else None,
189179
"function_call": None,
190180
},
191181
}

app/config.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,8 @@ class LLMSettings(BaseModel):
2626
description="Maximum input tokens to use across all requests (None for unlimited)",
2727
)
2828
temperature: float = Field(1.0, description="Sampling temperature")
29-
api_type: str = Field(..., description="Azure, Openai, Ollama or Bedrock")
29+
api_type: str = Field(..., description="Azure, Openai, or Ollama")
3030
api_version: str = Field(..., description="Azure Openai version if AzureOpenai")
31-
aws_access_key_id: str = Field(..., description="Aws access key id if Bedrock")
32-
aws_secret_access_key: str = Field(
33-
..., description="Aws secret access key if Bedrock"
34-
)
35-
aws_region_name: str = Field(..., description="Aws region name if Bedrock")
3631

3732

3833
class ProxySettings(BaseModel):
@@ -220,9 +215,6 @@ def _load_initial_config(self):
220215
"temperature": base_llm.get("temperature", 1.0),
221216
"api_type": base_llm.get("api_type", ""),
222217
"api_version": base_llm.get("api_version", ""),
223-
"aws_access_key_id": base_llm.get("aws_access_key_id", ""),
224-
"aws_secret_access_key": base_llm.get("aws_secret_access_key", ""),
225-
"aws_region_name": base_llm.get("aws_region_name", ""),
226218
}
227219

228220
# handle browser config.

app/llm.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,6 @@ def __init__(
203203
self.api_key = llm_config.api_key
204204
self.api_version = llm_config.api_version
205205
self.base_url = llm_config.base_url
206-
self.aws_access_key_id = llm_config.aws_access_key_id
207-
self.aws_secret_access_key = llm_config.aws_secret_access_key
208-
self.aws_region_name = llm_config.aws_region_name
209206

210207
# Add token counting related attributes
211208
self.total_input_tokens = 0
@@ -230,11 +227,7 @@ def __init__(
230227
api_version=self.api_version,
231228
)
232229
elif self.api_type == "aws":
233-
self.client = BedrockClient(
234-
aws_access_key_id=self.aws_access_key_id,
235-
aws_secret_access_key=self.aws_secret_access_key,
236-
aws_region_name=self.aws_region_name,
237-
)
230+
self.client = BedrockClient()
238231
else:
239232
self.client = AsyncOpenAI(api_key=self.api_key, base_url=self.base_url)
240233

config/config.example.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ temperature = 0.0 # Controls randomness
1313
# max_tokens = 8192
1414
# temperature = 1.0
1515
# api_key = "bear" # Required but not used for Bedrock
16-
# aws_access_key_id = "" # Required
17-
# aws_secret_access_key = "" # Required
18-
# aws_region_name = "us-west-2" # Required
1916

2017
# [llm] #AZURE OPENAI:
2118
# api_type= 'azure'

0 commit comments

Comments
 (0)