Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename node_modules to ternjs #211

Closed
paulvi opened this issue Dec 12, 2014 · 11 comments
Closed

Rename node_modules to ternjs #211

paulvi opened this issue Dec 12, 2014 · 11 comments
Milestone

Comments

@paulvi
Copy link
Contributor

paulvi commented Dec 12, 2014

started as #195 (comment)

inside https://github.com/angelozerr/tern.java/tree/master/core/tern.core/
rename node_modules to ternjs

Today the whole tern plugins are hosted inside https://github.com/angelozerr/tern.java/tree/master/core/tern.core/node_modules

I have not used npm for that, just copy/paste those tern plugins. So if you think those folder should be redone, don't hesitate to tell me. I think too this https://github.com/angelozerr/tern.java/tree/master/core/tern.core/node_modules should be deleted and move to a new Eclipse project tern.repository which hosts those tern plugins.

OK, for me it is not yet clear 100%

But for Node.js installed modules usually are to come into node_modules inside of new ternjs

Let's come up with word other than "repository" e.g. "ternjs folder" or "tern copy"

@angelozerr
Copy link
Owner

Let's come up with word other than "repository" e.g. "ternjs folder" or "tern copy"

why, inside tern.java it's a tern repository, no?

@paulvi
Copy link
Contributor Author

paulvi commented Dec 12, 2014

For me tern repository = https://github.com/marijnh/tern

OK, if check https://en.wikipedia.org/wiki/Repository one of the meaning is Repository clone,
and that is what we have.

Now I see

I think too this https://github.com/angelozerr/tern.java/tree/master/core/tern.core/node_modules should be deleted and move to a new Eclipse project tern.repository which hosts those tern plugins.

I think it will become confusing when inside https://github.com/angelozerr/tern.java/tree/master/core
there is tern.repository next to tern.core.
Isn't tern.core project a wrapper for tern? Then let tern be inside tern.core

@paulvi
Copy link
Contributor Author

paulvi commented Dec 12, 2014

It is just because java package is tern. and it create folder tern like

..
angular
doc
internal
metadata
repository
resources
scriptpath
server
utils
Activator.class
IDOMProvider.class
ITernAdaptable.class
ITernFile.class
ITernFileSynchronizer.class
ITernProject.class
ITernResourcesManagerDelegate.class
TernException.class
TernResourcesManager.class

So we can't put tern here

@paulvi
Copy link
Contributor Author

paulvi commented Dec 12, 2014

How do you actually run tern ? Do you use .bin folder?

@angelozerr
Copy link
Owner

Isn't tern.core project a wrapper for tern? Then let tern be inside tern.core

yes, but tern.core is able to use any tern repository.

My idea is to have 2 projects :

  • tern.core like today but which doesn't store ternjs
  • tern.repository which hosts ternjs + custom tern plugin. It's the default tern repository which is used inside tern.java.

User can define their own tern repository. In this case tern.core will use this custom tern repository.

@angelozerr
Copy link
Owner

How do you actually run tern ? Do you use .bin folder?

I use https://github.com/angelozerr/tern.java/blob/master/core/tern.core/node_modules/tern/bin/tern to start node tern server

@paulvi
Copy link
Contributor Author

paulvi commented Dec 12, 2014

So .bin folder is to be deleted.

Do you want to give option to run different tern version e.g. from specified location ?

I also still have doubts. Maybe we should have our own JavaScript project e.g. xtern
that has tern as dependency and is capable of installing plugins...
possibly have some tern extension that were not accepted into tern code base, etc

I would try to run it without java, have options to update plugins, install new,

@paulvi
Copy link
Contributor Author

paulvi commented Dec 12, 2014

I go home now. Will be offline for 2..15 hours

@angelozerr
Copy link
Owner

So .bin folder is to be deleted.

Ok

Do you want to give option to run different tern version e.g. from specified location ?

Tern repository exists for that. You can choose your tern location.

I also still have doubts. Maybe we should have our own JavaScript project e.g. xtern

I would like to move (if it's possible) https://github.com/angelozerr/tern.java/blob/master/core/tern.core/node_modules to a new project call tern.repository. This project will be the default repository, but you can customize your own tern repository.

I would try to run it without java, have options to update plugins, install new,

Ok

@angelozerr
Copy link
Owner

I would like to move (if it's possible) https://github.com/angelozerr/tern.java/blob/master/core/tern.core/node_modules to a new project call tern.repository. This project will be the default repository, but you can customize your own tern repository.

@paulvi are you OK with that?

@paulvi
Copy link
Contributor Author

paulvi commented Jan 27, 2015

sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants