Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PYTHON] Clear memory right at the end of destruction #77

Open
chaithyagr opened this issue Apr 27, 2020 · 2 comments
Open

[PYTHON] Clear memory right at the end of destruction #77

chaithyagr opened this issue Apr 27, 2020 · 2 comments

Comments

@chaithyagr
Copy link
Contributor

The current version of codes calls delete for gpuNUFFTOp on destruct.
However, I see that the GPU Memory is not cleared.
@andyschwarzl Do you have any idea what I could have missed and are we sure that there arent any memory leaks in the base set of codes?

@andyschwarzl
Copy link
Owner

The base set of the code should not lead to any GPU memory leaks, but what I've seen was memory fragmentation when working with the same device context and instantiating the gpuNUFFT operator several times.

@chaithyagr
Copy link
Contributor Author

Hmmm, interesting.
This seems to be a specific issue with python codes in that case. I have a feeling this comes up if the NUFFTOp object is not destroyed. Also, this could be due to the fact that memory ownership could be passed to python. I will look into this and try to get a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants