Skip to content

Commit befbc56

Browse files
authored
Fix Remainder of Calculation vs. Phpstan Issues (PHPOffice#3108)
* Fix Remainder of Calculation vs. Phpstan Issues I had tried to include these changes as part of an earlier effort, but something about them broke Phpstan. I removed them until I could determine the actual cause, which is ... The array `$phpSpreadsheetFunctions` is a very large and very complicated array, typehinted as `array`. It is declared as private static; however, its content never changes (at least not now - there are some outstanding proposals that might change that). I have had some success with changing unmodifiable private static to private const. However, such a change here causes Phpstan to perform a lot more processing and eventually time out. So, leave it as static. Having identified the cause of the problem, none of the other changes were problematic, so this PR applies the rest of them. * Scrutinizer One problem. * Scrutinizer False Positives Without Suggested Annotation See if minor code changes can make these go away. * Scrutinizer Still Experimenting Trying again.
1 parent de975e6 commit befbc56

File tree

6 files changed

+101
-652
lines changed

6 files changed

+101
-652
lines changed

0 commit comments

Comments
 (0)