Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staking] Add Amount for Unstaking Funds #453

Closed
daniel-wehbe opened this issue May 13, 2024 · 1 comment · Fixed by #458
Closed

[Staking] Add Amount for Unstaking Funds #453

daniel-wehbe opened this issue May 13, 2024 · 1 comment · Fixed by #458
Assignees
Labels
enhancement New feature or request

Comments

@daniel-wehbe
Copy link
Contributor

daniel-wehbe commented May 13, 2024

Description

The staking ADO has an Unstake message that undelegates tokens from the specified validator. Currently this message does not have an amount to specify how much funds to undelegate so it undelegates the total amount. If possible we would like to add the option to add an amount and if not specified would default to taking the maximum.

Also we might want to change the Claim message recipient to be of type Recipient instead of AndrAddr. This is to allow the rewards to be sent to another ADO which might be useful for some use cases:

  Claim {
        validator: Option<Addr>,
        recipient: Option<AndrAddr>,
    },

Acceptance Criteria

  • Unstaking takes an optional amount field to specify the number of tokens to unstake
  • Claim now has the option to send the rewards to another ADO (by using the Recipient struct instead of AndrAddr)
  • Unit test to confirm functionality
@daniel-wehbe daniel-wehbe added the enhancement New feature or request label May 13, 2024
@joemonem joemonem self-assigned this May 15, 2024
@joemonem joemonem linked a pull request May 15, 2024 that will close this issue
@joemonem
Copy link
Contributor

Did not replace AndrAddr with Recipient in the Claim msg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants