Skip to content

make ChannelMappingAudioProcessor, TrimmingAudioProcessor and ToFloatPcmAudioProcessor public UnstableApi instead of package-private #2339

Closed
@nift4

Description

@nift4

[REQUIRED] Use case description

I'm working on my own audio sink and started out by copy-pasting DefaultAudioSink into my project. After cleaning up some low-hanging fruits, I got quite a few errors because my sink can't access TrimmingAudioProcessor, ChannelMappingAudioProcessor and ToFloatPcmAudioProcessor; as they are package-private in another package. (I also got errors about AudioTrackPositionTracker and AudioDeviceInfoApi23, but those feel more like implementation details so no need to make them public.)

Proposed solution

Mark these classes as public @UnstableApi instead of package-private

Alternatives considered

I could of course copy paste them as well, but those are sufficiently abstracted and I'd never end up editing them, so that'd be suboptimal tbh.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions