Skip to content

Commit 70e7121

Browse files
toniheicopybara-github
authored andcommitted
Make some audio processors public
ChannelMappingAudioProcessor, TrimmingAudioProcessor and ToFloatPcmAudioProcessor are currently package-private even though they might be useful in custom audio processing chains or custom version of audio sinks. Issue: #2339 PiperOrigin-RevId: 747857815
1 parent 9cc7dd0 commit 70e7121

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

RELEASENOTES.md

+3
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
* DataSource:
2424
* Audio:
2525
* Allow constant power upmixing/downmixing in DefaultAudioMixer.
26+
* Make `ChannelMappingAudioProcessor`, `TrimmingAudioProcessor` and
27+
`ToFloatPcmAudioProcessor` public
28+
([#2339](https://github.com/androidx/media/issues/2339)).
2629
* Video:
2730
* Add experimental `ExoPlayer` API to include the
2831
`MediaCodec.BUFFER_FLAG_DECODE_ONLY` flag when queuing decode-only input

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/ChannelMappingAudioProcessor.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,16 @@
2323
import androidx.media3.common.audio.AudioProcessor;
2424
import androidx.media3.common.audio.BaseAudioProcessor;
2525
import androidx.media3.common.util.Assertions;
26+
import androidx.media3.common.util.UnstableApi;
2627
import java.nio.ByteBuffer;
2728
import java.util.Arrays;
2829

2930
/**
3031
* An {@link AudioProcessor} that applies a mapping from input channels onto specified output
3132
* channels. This can be used to reorder, duplicate or discard channels.
3233
*/
33-
/* package */ final class ChannelMappingAudioProcessor extends BaseAudioProcessor {
34+
@UnstableApi
35+
public final class ChannelMappingAudioProcessor extends BaseAudioProcessor {
3436

3537
@Nullable private int[] pendingOutputChannels;
3638
@Nullable private int[] outputChannels;

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/ToFloatPcmAudioProcessor.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import androidx.media3.common.Format;
2020
import androidx.media3.common.audio.AudioProcessor;
2121
import androidx.media3.common.audio.BaseAudioProcessor;
22+
import androidx.media3.common.util.UnstableApi;
2223
import androidx.media3.common.util.Util;
2324
import java.nio.ByteBuffer;
2425

@@ -34,7 +35,8 @@
3435
* <li>{@link C#ENCODING_PCM_FLOAT} ({@link #isActive()} will return {@code false})
3536
* </ul>
3637
*/
37-
/* package */ final class ToFloatPcmAudioProcessor extends BaseAudioProcessor {
38+
@UnstableApi
39+
public final class ToFloatPcmAudioProcessor extends BaseAudioProcessor {
3840

3941
private static final int FLOAT_NAN_AS_INT = Float.floatToIntBits(Float.NaN);
4042
private static final double PCM_32_BIT_INT_TO_PCM_32_BIT_FLOAT_FACTOR = 1.0 / 0x7FFFFFFF;

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/TrimmingAudioProcessor.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
import androidx.media3.common.C;
2121
import androidx.media3.common.Format;
2222
import androidx.media3.common.audio.BaseAudioProcessor;
23+
import androidx.media3.common.util.UnstableApi;
2324
import androidx.media3.common.util.Util;
2425
import java.nio.ByteBuffer;
2526

2627
/** Audio processor for trimming samples from the start/end of data. */
27-
/* package */ final class TrimmingAudioProcessor extends BaseAudioProcessor {
28+
@UnstableApi
29+
public final class TrimmingAudioProcessor extends BaseAudioProcessor {
2830

2931
private int trimStartFrames;
3032
private int trimEndFrames;

0 commit comments

Comments
 (0)