Add missing check for TRACK_TYPE_NONE before accessing selections

The track selections will be null if the track type is NONE even
if the renderer is enabled.

PiperOrigin-RevId: 747818128

Author: tonihei

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayerImplInternal.java

@@ -2651,7 +2651,8 @@ private void maybeUpdateReadingPeriod() throws ExoPlaybackException {
           hasSecondaryRenderers && !isPrewarmingDisabledUntilNextTransition;
       if (arePrewarmingRenderersHandlingDiscontinuity) {
         for (int i = 0; i < renderers.length; i++) {
-          if (!newTrackSelectorResult.isRendererEnabled(i)) {
+          if (!newTrackSelectorResult.isRendererEnabled(i)
+              || renderers[i].getTrackType() == C.TRACK_TYPE_NONE) {
             continue;
           }
           // TODO: This check should ideally be replaced by a per-stream discontinuity check

libraries/exoplayer/src/test/java/androidx/media3/exoplayer/ExoPlayerTest.java

@@ -679,9 +679,9 @@ public void renderersLifecycle_seekTo_resetsDisabledRenderersIfRequired() throws
   @Test
   public void renderersLifecycle_onlyRenderersThatAreEnabled_areSetToFinal() throws Exception {
     AtomicInteger videoStreamSetToFinalCount = new AtomicInteger();
-    final FakeRenderer videoRenderer = new FakeRenderer(C.TRACK_TYPE_VIDEO);
-    final FakeRenderer audioRenderer = new FakeRenderer(C.TRACK_TYPE_AUDIO);
-    final ForwardingRenderer forwardingVideoRenderer =
+    FakeRenderer videoRenderer = new FakeRenderer(C.TRACK_TYPE_VIDEO);
+    FakeRenderer audioRenderer = new FakeRenderer(C.TRACK_TYPE_AUDIO);
+    ForwardingRenderer forwardingVideoRenderer =
         new ForwardingRenderer(videoRenderer) {
           @Override
           public void setCurrentStreamFinal() {
@@ -694,18 +694,18 @@ public void setCurrentStreamFinal() {
                 new TestExoPlayerBuilder(context)
                     .setRenderers(forwardingVideoRenderer, audioRenderer))
             .build();
-    // Use media sources with discontinuities so that enabled streams are set to final.
+    // Use media sources with discontinuities so that enabled streams are set to final. Also ensure
+    // to use Formats that are not guaranteed to be only sync samples, so ClippingMediaSource
+    // maintains the initial discontinuity.
+    Format videoFormat = new Format.Builder().setSampleMimeType(MimeTypes.VIDEO_AV1).build();
+    Format audioFormat = new Format.Builder().setSampleMimeType(MimeTypes.AUDIO_DTS).build();
     ClippingMediaSource clippedFakeAudioSource =
-        new ClippingMediaSource.Builder(
-                new FakeMediaSource(new FakeTimeline(), ExoPlayerTestRunner.AUDIO_FORMAT))
+        new ClippingMediaSource.Builder(new FakeMediaSource(new FakeTimeline(), audioFormat))
             .setEndPositionMs(300)
             .build();
     ClippingMediaSource clippedFakeAudioVideoSource =
         new ClippingMediaSource.Builder(
-                new FakeMediaSource(
-                    new FakeTimeline(),
-                    ExoPlayerTestRunner.VIDEO_FORMAT,
-                    ExoPlayerTestRunner.AUDIO_FORMAT))
+                new FakeMediaSource(new FakeTimeline(), videoFormat, audioFormat))
             .setEndPositionMs(300)
             .build();
     player.setMediaSources(

libraries/exoplayer/src/test/java/androidx/media3/exoplayer/ExoPlayerWithPrewarmingRenderersTest.java

@@ -67,6 +67,7 @@
 import androidx.test.core.app.ApplicationProvider;
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import com.google.common.collect.ImmutableList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicReference;
@@ -1609,6 +1610,56 @@ public void render(long positionUs, long elapsedRealtimeUs)
     assertThat(secondaryVideoState3).isEqualTo(Renderer.STATE_STARTED);
   }
 
+  @Test
+  public void
+      play_withNoSampleRendererAndInitialDiscontinuity_usesPrewarmingAndTransitionsWithoutError()
+          throws Exception {
+    Clock fakeClock = new FakeClock(/* isAutoAdvancing= */ true);
+    RenderersFactory renderersFactoryWithNoSampleRenderer =
+        new FakeRenderersFactorySupportingSecondaryVideoRenderer(
+            fakeClock, /* includeNoSampleRenderer= */ true);
+    ExoPlayer player =
+        new TestExoPlayerBuilder(context)
+            .setClock(fakeClock)
+            .setRenderersFactory(renderersFactoryWithNoSampleRenderer)
+            .build();
+    Renderer secondaryVideoRenderer = player.getSecondaryRenderer(/* index= */ 0);
+    Renderer noSampleRenderer = player.getRenderer(/* index= */ 2);
+    assertThat(secondaryVideoRenderer.getTrackType()).isEqualTo(C.TRACK_TYPE_VIDEO);
+    assertThat(noSampleRenderer.getTrackType()).isEqualTo(C.TRACK_TYPE_NONE);
+    // Set a playlist that allows a new renderer to be enabled early and uses an initial
+    // discontinuity.
+    player.setMediaSources(
+        ImmutableList.of(
+            new FakeMediaSource(new FakeTimeline(), ExoPlayerTestRunner.VIDEO_FORMAT),
+            new FakeMediaSource(
+                new FakeTimeline(),
+                ExoPlayerTestRunner.VIDEO_FORMAT,
+                ExoPlayerTestRunner.AUDIO_FORMAT) {
+              @Override
+              public MediaPeriod createPeriod(
+                  MediaPeriodId id, Allocator allocator, long startPositionUs) {
+                FakeMediaPeriod fakeMediaPeriod =
+                    (FakeMediaPeriod) super.createPeriod(id, allocator, startPositionUs);
+                fakeMediaPeriod.setDiscontinuityPositionUs(100);
+                return fakeMediaPeriod;
+              }
+            }));
+    player.prepare();
+
+    // Play until secondary video renderer item is started, verifying its being used for prewarming.
+    // This step should not have any influence on the NoSampleRenderer and it should not throw.
+    player.play();
+    advance(player)
+        .untilBackgroundThreadCondition(
+            () -> secondaryVideoRenderer.getState() == Renderer.STATE_STARTED);
+    @Renderer.State int noSampleRendererState = noSampleRenderer.getState();
+    advance(player).untilState(Player.STATE_ENDED);
+    player.release();
+
+    assertThat(noSampleRendererState).isEqualTo(Renderer.STATE_STARTED);
+  }
+
   /** {@link FakeMediaSource} that prevents any reading of samples off the sample queue. */
   private static final class FakeBlockingMediaSource extends FakeMediaSource {
 
@@ -1670,9 +1721,16 @@ public int readData(
   private static class FakeRenderersFactorySupportingSecondaryVideoRenderer
       implements RenderersFactory {
     protected final Clock clock;
+    private final boolean includeNoSampleRenderer;
 
     public FakeRenderersFactorySupportingSecondaryVideoRenderer(Clock clock) {
+      this(clock, /* includeNoSampleRenderer= */ false);
+    }
+
+    public FakeRenderersFactorySupportingSecondaryVideoRenderer(
+        Clock clock, boolean includeNoSampleRenderer) {
       this.clock = clock;
+      this.includeNoSampleRenderer = includeNoSampleRenderer;
     }
 
     @Override
@@ -1684,10 +1742,25 @@ public Renderer[] createRenderers(
         MetadataOutput metadataRendererOutput) {
       HandlerWrapper clockAwareHandler =
           clock.createHandler(eventHandler.getLooper(), /* callback= */ null);
-      return new Renderer[] {
-        new FakeVideoRenderer(clockAwareHandler, videoRendererEventListener),
-        new FakeAudioRenderer(clockAwareHandler, audioRendererEventListener)
-      };
+      Renderer[] renderers =
+          new Renderer[] {
+            new FakeVideoRenderer(clockAwareHandler, videoRendererEventListener),
+            new FakeAudioRenderer(clockAwareHandler, audioRendererEventListener)
+          };
+      if (includeNoSampleRenderer) {
+        renderers = Arrays.copyOf(renderers, renderers.length + 1);
+        renderers[renderers.length - 1] =
+            new NoSampleRenderer() {
+              @Override
+              public String getName() {
+                return "NoSampleRenderer";
+              }
+
+              @Override
+              public void render(long positionUs, long elapsedRealtimeUs) {}
+            };
+      }
+      return renderers;
     }
 
     @Override

libraries/test_utils/src/main/java/androidx/media3/test/utils/ExoPlayerTestRunner.java

@@ -70,6 +70,7 @@ public final class ExoPlayerTestRunner implements Player.Listener, ActionSchedul
   public static final Format AUDIO_FORMAT =
       new Format.Builder()
           .setSampleMimeType(MimeTypes.AUDIO_AAC)
+          .setCodecs("mp4a.40.2")
           .setAverageBitrate(100_000)
           .setChannelCount(2)
           .setSampleRate(44100)