Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Gnuradio for v3.9.0 #28

Open
sergiomb2 opened this issue Feb 6, 2021 · 3 comments
Open

support Gnuradio for v3.9.0 #28

sergiomb2 opened this issue Feb 6, 2021 · 3 comments

Comments

@sergiomb2
Copy link

gr-dab FTBFS with fedora rawhide , seems is the same problem of

drmpeg/gr-dvbs2rx#10
drmpeg/gr-dvbs2#7

@yarda
Copy link
Contributor

yarda commented Feb 11, 2021

Gnuradio 3.9 is stable. It drops swig and uses pybind, so OOTs needs some changes. There is porting guide https://wiki.gnuradio.org/index.php/GNU_Radio_3.9_OOT_Module_Porting_Guide

We are trying to rebase gnuradio to 3.9 in Fedora Rawhide. I could try to do some preliminary port.

@yarda
Copy link
Contributor

yarda commented Feb 24, 2021

We used the following patch in Fedora / RPM Fusion downstream:
https://pkgs.rpmfusion.org/cgit/free/gr-dab.git/tree/gr-dab-0.4-gnuradio39.patch
It's untested and without any warranty. Todo: Fix naming (dab vs grdab) - we workaround it dirty way by using symlinks. Also fix QA tests.

@elafargue
Copy link

elafargue commented Jun 22, 2021

Working on the fix right now, standardizing on grdab as the module name everywhere. Note that Gnuradio 3.9 has changed quite a few APIs as well, so there will be a need to fix a couple of calls like this one:

self.conv_decode = trellis.viterbi_combined_fb(self.fsm, 774, 0, 0, 4, table, trellis.TRELLIS_EUCLIDEAN)
AttributeError: module 'gnuradio.trellis' has no attribute 'viterbi_combined_fb'

If someone is interested to help, I can push my current changes to github to collaborate, let me know

See https://github.com/elafargue/gr-dab/commits/maint-3.9 for my work so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants