Rename the parameter title to summary

Author: andreztz

notify/linux/notify.py

@@ -23,17 +23,12 @@ class LinuxNotification:
         image: The icon filename or icon theme-compliant name
     """
 
-    def __call__(
-        self,
-        message,
-        title="",
-        timeout=2000,
-        **kwargs
-    ):
-        app_name = kwargs.get('app_name', 'notify-send')
-        image = kwargs.get('image', 'dialog-information')
-
+    def __call__(self, summary, message="", timeout=2000, **kwargs):
+        app_name = kwargs.get("app_name", "notify-send")
+        image = kwargs.get("image", "dialog-information")
         Notify.init(app_name)
-        n = Notify.Notification.new(title, message, image)
+        n = Notify.Notification.new(message, summary, image)
         n.set_timeout(timeout)
         n.show()
+        return n.close()
+

notify/notification.py

@@ -20,10 +20,10 @@
 
 try:
     modulo = import_module("." + platform, __package__)
-except:
+except Exception:
     raise RuntimeError("Unsupported operating system: {}".format(sys.platform))
 else:
-    send = getattr(modulo, "{}Notification".format(platform.title()))()
+    caller = getattr(modulo, "{}Notification".format(platform.title()))()
 
 
 class Notification:
@@ -38,15 +38,19 @@ class Notification:
         **kwargs: Additional arguments (optional).
     """
 
-    def __init__(self, message, title="", timeout=2000, **kwargs):
+    def __init__(self, summary, message="", timeout=2000, **kwargs):
+        self.summary = summary
         self.message = message
-        self.title = title
         self.timeout = timeout
         self.kwargs = kwargs
 
     def __call__(self):
-        send(self.message, self.title, self.timeout, **self.kwargs)
+        status = caller(
+            self.message, self.summary, self.timeout, **self.kwargs
+        )
+        return status
 
 
-def notification(message, title="", timeout=2000, **kwargs):
-    Notification(message, title, timeout, **kwargs)()
+def notification(summary, message="", timeout=2000, **kwargs):
+    status = Notification(summary, message, timeout, **kwargs)()
+    return status

notify/win32/notify.py

@@ -46,7 +46,7 @@ class Win32Notification:
     def __init__(self):
         self.message_map = {win32con.WM_DESTROY: self.OnDestroy}
 
-    def __call__(self, message="", title="", timeout=2000, **kwargs):
+    def __call__(self, summary, message="", timeout=2000, **kwargs):
         tip = kwargs.get("tip", "Balloon tooltip")
 
         # Register the Window class.
@@ -83,7 +83,7 @@ def __call__(self, message="", title="", timeout=2000, **kwargs):
             hicon = LoadImage(
                 hinst, iconPathName, win32con.IMAGE_ICON, 0, 0, icon_flags
             )
-        except:
+        except Exception:
             hicon = LoadIcon(0, win32con.IDI_APPLICATION)
 
         flags = NIF_ICON | NIF_MESSAGE | NIF_TIP
@@ -102,12 +102,13 @@ def __call__(self, message="", title="", timeout=2000, **kwargs):
                 tip,
                 message,
                 timeout,
-                title,
+                summary,
             ),
         )
         # Destroy
         DestroyWindow(self.hwnd)
         classAtom = UnregisterClass(classAtom, hinst)
+        return True
 
     def OnDestroy(self, hwnd, msg, wparam, lparam):
         nid = (self.hwnd, 0)

tests/test_notification.py

@@ -7,9 +7,10 @@ def test_if_notification_is_callable():
 
 
 def test_notification_function():
-    notification("hello world", title="optinal")
+    status = notification("hello world", message="optinal")
+    assert status is True
 
 
 def test_notification_class():
-    Notification("Hello World", title="optional")()
-    
+    status = Notification("Hello World", message="optional")()
+    assert status is True