-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current SugarJS incompatible with current Thunderbird (probably also Firefox?) trunk #627
Comments
OK, so I've figured out a workaround for this. do with it what you will:
|
See also https://groups.google.com/forum/#!topic/firefox-dev/J2frGYCb7Rg. It looks like this is coming down the pike for Firefox too, not just Thunderbird. |
I also had this problem when using Angular CLI (Webpack) and trying to use Sugar (in Chrome). @jikamens patch fixed it for me as well. Thanks! Please use this patch in future versions of Sugar! |
@jikamens Thank you for this fix and very sorry for the delay here. I believe the fix in #632 should work here as well, although it's strange that they're occurring at similar times as that one should be related to webpack. In any case it's time to overall tighten down the assumptions I'm making about the environment Sugar is running in so I think for now referencing |
@jikamens Also mind sharing how you're testing Thunderbird? |
"Testing"? ;-) My Thunderbird add-on (Send Later) wasn't working properly without my fix. It's working with it. That's the extent of my testing. |
If you mean the fix in 0cd73d1, nope, it's not working. When I build a custom version of SugarJS from the Git repo using gulp and try to load it into current Thunderbird, the interpreter complains |
If we can't get the global contest from either `global` or `window` and `Cu.getGlobalForObject` exists, then use that. See https://developer.mozilla.org/docs/Mozilla/Tech/XPCOM/Language_Bindings/Components.utils.getGlobalForObject. Fixes andrewplummer#627.
If we can't get the global contest from either `global` or `window` and `Cu.getGlobalForObject` exists, then use that. See https://developer.mozilla.org/docs/Mozilla/Tech/XPCOM/Language_Bindings/Components.utils.getGlobalForObject. Fixes andrewplummer#627.
Attempting to use SugarJS with the 2018-03-15 Thunderbird Trunk build, I get this:
I imagine this is also going to impact Firefox since Thunderbird and Firefox share a JavaScript engine.
The trunk build from three days ago does not have this problem. The build transitioned from Thunderbird 60 to Thunderbird 61 in the interim, so I imagine this problem was introduced by a change that was held out of the trunk until the bump from 60 to 61.
The text was updated successfully, but these errors were encountered: