Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Inconsistency with UB Commander product categorization. #230

Open
ElectroShade opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
bug issues that require immediate attention discussion should probably move to discussions tab documentation anything related to the docs site

Comments

@ElectroShade
Copy link

Hello. I noticed a small inconsistency regarding how the UB Commander products are being categorized on the site:

https://keyrune.andrewgioia.com/icons.html

Specifically the "Warhammer 40K" is categorized under "Command Zone Sets" while "UB: Doctor Who" and "UB: Fallout" are listed under "Other Supplemental Products". All 3 of these are sets of 4 commander decks so it seems like they should be categorized under one or the other for consistency.

Alternatively could consider creating a new "Universes Beyond" category to put them all in as well (+ LoTR, AC, Transformers, Jurassic Park).

@ElectroShade ElectroShade changed the title Documentation Inconsistency for UB Commander products. [Documentation] Inconsistency for UB Commander product categorization. Apr 16, 2024
@ElectroShade ElectroShade changed the title [Documentation] Inconsistency for UB Commander product categorization. [Documentation] Inconsistency with UB Commander product categorization. Apr 16, 2024
@andrewgioia andrewgioia self-assigned this Oct 28, 2024
@andrewgioia andrewgioia added bug issues that require immediate attention documentation anything related to the docs site labels Oct 28, 2024
@andrewgioia
Copy link
Owner

Thanks for the catch here, yeah I agree I think I've struggled with how to categorize those. Some of them are Commander only but others ones like LotR go beyond that, or sets like Ravnica Clue Edition was like a self-contained supplemental set.

I think this issue is now going to be exacerbated by the introduction into Standard for a lot of these going forward too.

My vote would be to categorize them as appropriately as possible without regard to their UB status, so the sets you listed (40K, WHO, PIP) should be Command Zone Sets. Universes Beyond is more of a label or quality at this point.

@andrewgioia andrewgioia added the discussion should probably move to discussions tab label Oct 28, 2024
@ElectroShade
Copy link
Author

That makes sense to me both for now and future sets. So for now just need to move WHO and PIP under Command Zone Sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues that require immediate attention discussion should probably move to discussions tab documentation anything related to the docs site
Projects
None yet
Development

No branches or pull requests

2 participants