Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foil property prioritiy changed in latest build #228

Open
kodawah opened this issue Mar 8, 2024 · 3 comments
Open

Foil property prioritiy changed in latest build #228

kodawah opened this issue Mar 8, 2024 · 3 comments
Assignees
Labels
bug issues that require immediate attention

Comments

@kodawah
Copy link

kodawah commented Mar 8, 2024

It seems like in today's build of the library applying rarity + foil gives priority to the rarity color rather than the foil status

in other words ss ss-mbs ss-mythic ss-foil ss-grad ss-2x ss-fw has the same effect as ss ss-mbs ss-mythic ss-grad ss-2x ss-fw whereas in the past the foil gradient was always applied across any rarity

The same doesn't apply for other effects like ss-timeshifted so it makes me believe that was an unintentional change. Or is it expected behavior and rarity should be omitted when the foil gradient is present?

Thank you

kodawah added a commit to mtgban/mtgban-website that referenced this issue Mar 14, 2024
@andrewgioia
Copy link
Owner

So sorry for the late reply here. This definitely wouldn't have been intentional, it must have been a mistake on my part of some collateral damage to a change I didn't fully think through.

Foil should override all I believe, as it was originally implemented (?), and I can make that the order of priority again in 3.16.1.

@andrewgioia andrewgioia added the bug issues that require immediate attention label Oct 28, 2024
@andrewgioia andrewgioia self-assigned this Oct 28, 2024
@andrewgioia
Copy link
Owner

@kodawah I believe this is corrected now if you want to take a look and confirm!

@kodawah
Copy link
Author

kodawah commented Dec 17, 2024

hi @andrewgioia I believe the update fixed the issue of the foil rarity, but broke all the borders around the foil icons. Please the the pictures for an example

before
before

after
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues that require immediate attention
Projects
None yet
Development

No branches or pull requests

2 participants