AC-3520: Removed unneeded if

svera · svera · commit 31335a0a1fd5 · 2022-06-20T16:45:25.000+02:00
diff --git a/Magento2/Sniffs/Less/ColonSpacingSniff.php b/Magento2/Sniffs/Less/ColonSpacingSniff.php
@@ -61,11 +61,9 @@ private function needValidateSpaces(File $phpcsFile, $stackPtr, $tokens)
         }
 
         // Avoid false positives when parsing pseudo-classes
-        if ($tokens[$stackPtr]['code'] === T_COLON) {
-            $next = $phpcsFile->findNext([T_SEMICOLON, T_OPEN_CURLY_BRACKET], $stackPtr + 1);
-            if ($tokens[$next]['code'] === T_OPEN_CURLY_BRACKET) {
-                return false;
-            }
+        $next = $phpcsFile->findNext([T_SEMICOLON, T_OPEN_CURLY_BRACKET], $stackPtr + 1);
+        if ($tokens[$next]['code'] === T_OPEN_CURLY_BRACKET) {
+            return false;
         }
 
         $prev = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($stackPtr - 1), null, true);

Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,9 @@ private function needValidateSpaces(File $phpcsFile, $stackPtr, $tokens)`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`// Avoid false positives when parsing pseudo-classes`
`64`		`- if ($tokens[$stackPtr]['code'] === T_COLON) {`
`65`		`- $next = $phpcsFile->findNext([T_SEMICOLON, T_OPEN_CURLY_BRACKET], $stackPtr + 1);`
`66`		`- if ($tokens[$next]['code'] === T_OPEN_CURLY_BRACKET) {`
`67`		`- return false;`
`68`		`- }`
	`64`	`+ $next = $phpcsFile->findNext([T_SEMICOLON, T_OPEN_CURLY_BRACKET], $stackPtr + 1);`
	`65`	`+ if ($tokens[$next]['code'] === T_OPEN_CURLY_BRACKET) {`
	`66`	`+ return false;`
`69`	`67`	`}`
`70`	`68`
`71`	`69`	`$prev = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($stackPtr - 1), null, true);`