You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
the addressed problem of your application is interested.
But: you created a very "interesting" domain model;) instead of creating services for admin you connected your products with all order and/or order items. So nearly all objects in your model belong together.
And the additional problem is, that the jsps should handle on old products (inside the session) and orderlists while changing attributes so there is in combination with your problematic domain model a facility for lazy loading exceptions during update when a client ordered some items.
The transaction-problem is the least problem;)
I made some changes for solving most of the fails in my own branch, and I can make a PR:
setup transaction management
created a new page for not proceeded order
ensure , that updates and deletes by admin work whatever clients order
(but there are possible fails too, e.g. an admin-user tries to update a product during an other admin-user deletes the same product)
There is at least one functional fail (should probably solved by a new issue):
if the price of an product is changed, the price is changed in all orders too (I think no customer will accept such behavior, he want's the product with the old price ;) )
But I think there should be some other important issues:
change domain model with lower belongings
create AdminServices for displaying statistics
transfer most of the logic (building sums, etc) into the services or (better) domain objects
perhaps using optimistic locking in your domain model
using Long instead of long for entity-id
Give me a hint, if I should make a PR for the topics above :)
The text was updated successfully, but these errors were encountered:
Hi,
the addressed problem of your application is interested.
But: you created a very "interesting" domain model;) instead of creating services for admin you connected your products with all order and/or order items. So nearly all objects in your model belong together.
And the additional problem is, that the jsps should handle on old products (inside the session) and orderlists while changing attributes so there is in combination with your problematic domain model a facility for lazy loading exceptions during update when a client ordered some items.
The transaction-problem is the least problem;)
I made some changes for solving most of the fails in my own branch, and I can make a PR:
(but there are possible fails too, e.g. an admin-user tries to update a product during an other admin-user deletes the same product)
There is at least one functional fail (should probably solved by a new issue):
But I think there should be some other important issues:
Give me a hint, if I should make a PR for the topics above :)
The text was updated successfully, but these errors were encountered: