fix(Examples): Fixed PHY selection bug in RF Test #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32655
|
/clang-format-run |
kevin-gillespie
requested changes
Nov 5, 2024
| @@ -706,7 +706,8 @@ void txTestTask(void *pvParameters) | |||
| if (testConfig.testType == BLE_TX_TEST) { | |||
| res = LlEnhancedTxTest(testConfig.channel, packetLen, packetType, phy, 0); | |||
| } else { | |||
| res = LlEnhancedRxTest(testConfig.channel, phy, 0, 0); | |||
| // Transmitters decision if it is S2 or S8. | |||
| res = LlEnhancedRxTest(testConfig.channel, LL_PHY_LE_CODED, 0, 0); | |||
There was a problem hiding this comment.
Do we need a conditional like this?
if(phy == LL_PHY_LE_CODED_S2 || phy == LL_PHY_LE_CODED_S2 ) {
phy = LL_PHY_LE_CODED;
}
|
/clang-format-run |
kevin-gillespie
approved these changes
Nov 7, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Nov 7, 2024
EricB-ADI
added a commit
that referenced
this pull request
Jan 6, 2025
Co-authored-by: EricB-ADI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated example to pass the coded mode option instead of the S2 or S8 option.
Addresses #1249