Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMCM-1140: critical max_current setting in rotate_demo.py #97

Open
ThoHiller opened this issue Oct 13, 2023 · 1 comment
Open

TMCM-1140: critical max_current setting in rotate_demo.py #97

ThoHiller opened this issue Oct 13, 2023 · 1 comment

Comments

@ThoHiller
Copy link

Hi guys,

I don't know if this is the correct way to report "bugs" in your example routines, but as this one can be quite harmful to the motor, I am giving it a shot.

In line 22 of the rotate_demo.py the value max_current (AP paramter 6) ist set:

motor.drive_settings.max_current = 1000

According to the firmware manual (Firmware Version V1.47 | Document Revision V1.10 • 2021-NOV-02) the value should be between 0 and 255. Large values might damage the motor.
I did not actually test what happens if one tries to set the value to 1000 as I am using a TMCM-1110 (based on your suggestion in #95) but I assume the problem (if any) will occur there too. I do not know if a value of 1000 is just "downcasted" to 255 or if an error message is given.

cheers,
Thomas

Addendum:
Based on the Firmware manual of the TMCM-1110 (Firmware Version V1.13 | Document Revision V1.08 • 2021-NOV-16), the output of the TMCL-IDE 3.0 and the python code for the TMCM-1140 module, I wrote the module code for the missing TMCM-1110. If you guys are interested to implement it just let me know.

@ThoHiller ThoHiller changed the title Critical current setting in exmaple rotate_demo.py for TMCM-1140 TMCM-1140: critical max_current setting in rotate_demo.py Oct 13, 2023
@trinamic-bp
Copy link
Contributor

Thank you Thomas, this looks indeed wrong, we will have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants