Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcpConnectionImpl.cc logs the connections aborted by a client as an unexpected error #278

Open
VladlenPopolitov opened this issue Aug 9, 2023 · 0 comments

Comments

@VladlenPopolitov
Copy link
Contributor

TcpConnectionImpl.cc line 482

               if (errno == EPIPE || errno == ECONNRESET)  // TODO: any others?
                {
#ifdef _WIN32
                    LOG_TRACE << "WSAENOTCONN or WSAECONNRESET, errno="
                              << errno;
#else
                    LOG_TRACE << "EPIPE or ECONNRESET, errno=" << errno;
#endif
                    return;
                }
                LOG_SYSERR << "Unexpected error(" << errno << ")";
                return;

If client aborted connection (it has a right to do it in any moment, and it is not error in program logic (though error of write function), it should not be logged as unexpected error to attract attention. It should be or silenced, or reported as "Client aborted connection"
Otherwise, it look like error in the program code.

errno == 10053 , WSAECONNABORTED in Windows.

@VladlenPopolitov VladlenPopolitov changed the title TcpConnectionImpl.cc logs the connection sorted by client as unexpected error TcpConnectionImpl.cc logs the connections aborted by a client as an unexpected error Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant