Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of default exports, use named exports only #1274

Open
jorenbroekema opened this issue Jul 12, 2024 · 0 comments
Open

Get rid of default exports, use named exports only #1274

jorenbroekema opened this issue Jul 12, 2024 · 0 comments
Labels
5.0 Might plan for v5 since it's breaking discuss enhancement
Milestone

Comments

@jorenbroekema
Copy link
Collaborator

import { StyleDictionary } from 'style-dictionary';

Also use named imports everywhere internally.

All public utils/types are already named, just the default import StyleDictionary is the exception.
It would be good to discuss whether breaking this and making it a named import is worth it or if it's not valuable enough to cause a breaking change.

@jorenbroekema jorenbroekema added enhancement 5.0 Might plan for v5 since it's breaking discuss labels Jul 12, 2024
@jorenbroekema jorenbroekema added this to the 5.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 Might plan for v5 since it's breaking discuss enhancement
Projects
None yet
Development

No branches or pull requests

1 participant