Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add new configuration for grx #39649

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

nikolaospanagopoulos
Copy link
Contributor

Adding some new configuration for the Adman advertising.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@amp-owners-bot amp-owners-bot bot requested a review from calebcordry November 27, 2023 09:54
@nikolaospanagopoulos
Copy link
Contributor Author

on behalf of Phaistos Networks for Adman ad-server

@kornarakis
Copy link

Hello :) could you kindly review and approve this pull request? All tests have passed. Thank you!

@anmarkom
Copy link

Could you please evaluate the current PR?

This supports the new version of the Adman ad-server, Grxchange.gr, by Phaistos Networks S.A..

@kornarakis
Copy link

Hi @calebcordry. Could you please review this pull request? Thank you very much in advance.

@itzagkarakis
Copy link

itzagkarakis commented Dec 20, 2023

Hello @calebcordry !
Could you please evaluate the current PR?
This is about Grxchange.gr, by Phaistos Networks S.A.

@calebcordry calebcordry requested a review from powerivq December 20, 2023 17:24
@powerivq powerivq merged commit 0425729 into ampproject:main Dec 21, 2023
10 checks passed
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
* add new configuration for grx

* fix: previous errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants