-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve block placeholder styles to make it easier to see an empty element when it is added in a layer on top of another. #1560
Comments
AC 2: If we can start by just adding margin between elements, it should solve usability by spacing all elements out a tad. We'll let the dev team take a stab at this and see if it works. |
There's a further issue, which may be for this ticket, where a layer has a paragraph, and another layer has a paragraph, and they're right on top of each other; in that case it's very hard to see the paragraph of text from one layer to the next, since they overlap. One suggestion was to put a 50% white opacity between layers to make them less visible. |
I mocked up a graphic to show what 50% opacity will do for us. It does help, but it seems like it is not enough. I am not sure how this would be done in terms of development but... I included the 50% white opacity layer between the top and lower layer and then I also added a blur effect on the lower layer which in combination with the 50% white opacity made the top layer much better to work on... here is a .gif Does this seem possible? :) This blur effect maintains the lower layer colors for ease of editing with different color fonts. |
Here is a better visual of the blur effect... |
@miina Do you think the blur effect is viable? For ac2? |
@cathibosco Looks like blur possibly together with opacity 50% background could work well. We could try it out and then see how it looks like! And then think of alternatives if it still feels like not clear enough. Thoughts? |
@miina - I've updated the AC here and assumed that the all the items here are covered in other issues as referenced. However, it may be easier from a development perspective to leave the move of the add layer interface change in this issue and remove it from the AC for #1563 Ideally, we could close issues that are covered off in 'other' issues, to clear the board, but there might be a reason, to keep the functionality separated. Thoughts? |
@alcurrie Good point, the issues are quite related to each other and I think it makes sense to close this issue and resolve the AC-s within the tickets where they make sense. No reason to keep the functionality separated, it makes more sense to develop the issues together that are very closely related. |
Thanks @miina Per discussion above, we are closing this as the Acceptance criteria for this issue will be resolved by #1563 and #1524 cc. @westonruter |
As an AMP Story author, I'd like improved styling/interface so that it's easier to see an empty element when it is added in a layer on top of another layer.
Related to #1563 #1564 #1541 #1559
The text was updated successfully, but these errors were encountered: