You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The linter should recognize both 2. and 3. but only recommend one of the two, obviously. I think to remember that there was currently a transitional period that favored one over the other, so I'm unsure what the final verdict is.
The linter currently doesn't use a separate recommendation for ESM preloads:
amp-toolbox/packages/linter/src/rules/RuntimeIsPreloaded.ts
Line 13 in 153d76b
This is misleading, and might even lead to frustration if users blindly apply the recommendation and it doesn't solve the issue.
The linter should properly differentiate between:
.js
withrel=preload
.mjs
withrel=preload
.mjs
withrel=modulepreload
The recommendation should then be generated accordingly so that applying the recommendation verbatim will actually fix the shown issue.
The text was updated successfully, but these errors were encountered: