Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API gateway custom domain names #629

Open
FreddieCarre opened this issue Apr 30, 2024 · 1 comment
Open

Update API gateway custom domain names #629

FreddieCarre opened this issue Apr 30, 2024 · 1 comment

Comments

@FreddieCarre
Copy link

FreddieCarre commented Apr 30, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Feature Request

Is your feature request related to a problem? Please describe.
I need to update the certificate used by the API gateway created by serverless-domain-manager. As the old certificate references a domain we no longer own and so cannot auto-renew the cert over DNS.

Describe the solution you'd like
If a custom domain already exists, use the updateDomainName sdk call to apply the config to the existing domain name. No change to the serverless template is necessary, although could add a flag so users can disable this behaviour if they're happy with the current implementation. May be better to do this as an 'opt-in' so that there is no change for your current users who do not need to update in place.

custom:
  customDomain:
    domainName: foo.example.tld
    certificateArn: arn:......
    skipUpdate: false

Describe alternatives you've considered
Writing our own sls hook to create / update domain names on api gateway

Any Other Info
If you can, maybe sketch out implementation details? If you've started a PR for this feature, link it here.
Happy to raise PR as I made some changes to the local node_module code and managed to update our custom domain name successfully.

@FreddieCarre
Copy link
Author

I have a branch with the initial changes, but do not have permissions to push to the repo 🤔 let me know if I can share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant