Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http1Driver::stop does not wait for requests #367

Open
brstgt opened this issue May 3, 2024 · 0 comments
Open

Http1Driver::stop does not wait for requests #367

brstgt opened this issue May 3, 2024 · 0 comments

Comments

@brstgt
Copy link
Contributor

brstgt commented May 3, 2024

It's possible that HTTP 1 requests still arrive or are in progress after the HTTP server actually stopped.

It's because pendingResponse is being waited for in stop() but not set for HTTP1 requests without chunks + content length (like pretty much all GET requests).

Suggestion:
http_server_shutdown.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brstgt