Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated call async_forward_entry_setup #309

Closed
tjorim opened this issue Jul 10, 2024 · 5 comments · Fixed by #326
Closed

Deprecated call async_forward_entry_setup #309

tjorim opened this issue Jul 10, 2024 · 5 comments · Fixed by #326

Comments

@tjorim
Copy link

tjorim commented Jul 10, 2024

Problem

Logger: homeassistant.helpers.frame
Source: helpers/frame.py:184
First occurred: 01:27:18 (11 occurrences)
Last logged: 01:27:49

Detected that custom integration 'tplink_deco' calls async_forward_entry_setup for integration, tplink_deco with title: http://192.168.0.98 and entry_id: 01J2CMRZZ59RQGH8WADMCRJ00N, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/tplink_deco/init.py, line 166: config_entry.async_create_task(, please create a bug report at https://github.com/amosyuen/ha-tplink-deco/issues

TP-Link Deco Version

v3.6.3

Router Model

n/a

Debugging Information

Logging should suffice.

@gcoan
Copy link

gcoan commented Jul 12, 2024

I get the same message but also get a second message saying it will stop working in 2025.1:

2024-07-12 21:10:39.504 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'tplink_deco' calls async_forward_entry_setup for integration, tplink_deco with title: 192.168.1.101 and entry_id: 760741b0e8f7b7503e54fb7c71a67a81, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/tplink_deco/__init__.py, line 166: config_entry.async_create_task(, please create a bug report at https://github.com/amosyuen/ha-tplink-deco/issues
2024-07-12 21:10:39.554 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration tplink_deco with title: 192.168.1.101 and entry_id: 760741b0e8f7b7503e54fb7c71a67a81, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

tp-link deco version 3.6.2

@Eirik78
Copy link

Eirik78 commented Dec 28, 2024

When will the fix be published??

@gcoan
Copy link

gcoan commented Dec 28, 2024

I've removed the TP Link Deco integration now. It wasn't adding a great deal to HA, the sensors were filling up the database and I wasn't really using it

@Eirik78
Copy link

Eirik78 commented Dec 30, 2024

So then you should immediately grant publish option to those submitting fixes instead of not approving them.

@gcoan
Copy link

gcoan commented Dec 30, 2024

So then you should immediately grant publish option to those submitting fixes instead of not approving them.

I think you are confused, I am (was) a co-user of the integration, I have no control over the codebase. I just commented that whilst I had in the past seen the same code issue I had now stopped using the integration.

If there is a code fix out there then it's easy enough to swap to that author's fork if the original developer has stopped maintaining it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants