Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Vlasov objects #140

Open
manauref opened this issue Sep 22, 2023 · 1 comment
Open

Separate Vlasov objects #140

manauref opened this issue Sep 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@manauref
Copy link
Collaborator

Vlasov objects are growing in complexity. I propose that we separate them, especially in the app system.

For example, when you look at the MaxwellField app there are lots of if-statements where it checks whether the plasmaB exists, if it does then it assumes VM, otherwise it assumes VP. Maybe we should just have separate Maxwell and Poisson apps. Just an idea.

Of course there are other models that add further complexity (SR Vlasov, PKPM) in both the field and the species code. Some of this could be simplified with separation.

Reason for this proposal: to reduce risk of breaking one model when modifying another.

@manauref manauref added the enhancement New feature or request label Sep 22, 2023
@ammarhakim
Copy link
Owner

We need to wait on this for a short while before the separation. We are trying to wrap some of the Vlasov-App code via Lua-C API directly to make the process less error prone. It will also simplify this refactoring proposed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants