Skip to content

Commit be48ad2

Browse files
gkalpakjosephperrott
authored andcommitted
docs(dev-infra): fix command and typos in browsers/README.md (angular#40150)
This commit fixes the instructions in `dev-infra/browsers/README.md` to use the `shasum` executable (instead of `sha256`, which does not exist afaict). The commit also fixes a couple of typos. PR Close angular#40150
1 parent 3aead9a commit be48ad2

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

dev-infra/browsers/README.md

+9-6
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ The process of updating the Chrome or Firefox version is not straightforward, bu
3434
Chromium 83.0.4103.0
3535
```
3636

37-
3. Update the chrome & chrome driver build numbers in `dev-infra/browsers/chromium/chromium.bzl` and run either run `bazel query @org_chromium_chromium_amd64//...` to prompt Bazel to calculate the new `sha256` for each platform binary or determine the new `sha256` values manually.
37+
3. Update the chrome & chrome driver build numbers in `dev-infra/browsers/chromium/chromium.bzl` and either run `bazel query @org_chromium_chromium_amd64//...` to prompt Bazel to calculate the new `sha256` for each platform binary or determine the new `sha256` values manually.
3838

3939
Here is an example with `curl` & `shasum`:
4040
``` bash
@@ -55,7 +55,7 @@ and their corresponding `yarn.lock` files.
5555
## Firefox
5656

5757
In order to update Firefox, open the `dev-infra/browsers/firefox/firefox.bzl` file and update the repository URLs to the desired version.
58-
e.g.
58+
For example:
5959

6060
```bzl
6161
platform_http_file(
@@ -67,8 +67,11 @@ platform_http_file(
6767
)
6868
```
6969

70-
Go to the `urls` property and update the URL by replacing all `78.0` occurrences with the version you intend to use.
71-
Once done, do the same change for other platforms (such as `macos`).
70+
1. Go to the `urls` property and update the URL by replacing all `78.0` occurrences with the version you intend to use.
71+
Once done, do the same change for other platforms (such as `macos`).
7272

73-
Finally, update the `sha256` checksum of the browser archives.
74-
You can do this by downloading the artifacts from the URLs you just updated, and then running on those files: `sha256 <path>`.
73+
2. Update the `sha256` checksum of the browser archives.
74+
You can do this by downloading the artifacts from the URLs you just updated, and then running `shasum` on those files:
75+
```sh
76+
curl <BROWSER_URL> | sha256 -a 256
77+
```

0 commit comments

Comments
 (0)