You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(dev-infra): fix command and typos in browsers/README.md (angular#40150)
This commit fixes the instructions in `dev-infra/browsers/README.md` to
use the `shasum` executable (instead of `sha256`, which does not exist
afaict).
The commit also fixes a couple of typos.
PR Closeangular#40150
Copy file name to clipboardExpand all lines: dev-infra/browsers/README.md
+9-6
Original file line number
Diff line number
Diff line change
@@ -34,7 +34,7 @@ The process of updating the Chrome or Firefox version is not straightforward, bu
34
34
Chromium 83.0.4103.0
35
35
```
36
36
37
-
3. Update the chrome & chrome driver build numbers in`dev-infra/browsers/chromium/chromium.bzl` and run either run `bazel query @org_chromium_chromium_amd64//...` to prompt Bazel to calculate the new `sha256`for each platform binary or determine the new `sha256` values manually.
37
+
3. Update the chrome & chrome driver build numbers in`dev-infra/browsers/chromium/chromium.bzl` and either run `bazel query @org_chromium_chromium_amd64//...` to prompt Bazel to calculate the new `sha256`for each platform binary or determine the new `sha256` values manually.
38
38
39
39
Here is an example with `curl`&`shasum`:
40
40
``` bash
@@ -55,7 +55,7 @@ and their corresponding `yarn.lock` files.
55
55
## Firefox
56
56
57
57
In order to update Firefox, open the `dev-infra/browsers/firefox/firefox.bzl` file and update the repository URLs to the desired version.
58
-
e.g.
58
+
For example:
59
59
60
60
```bzl
61
61
platform_http_file(
@@ -67,8 +67,11 @@ platform_http_file(
67
67
)
68
68
```
69
69
70
-
Go to the `urls` property and update the URL by replacing all `78.0` occurrences with the version you intend to use.
71
-
Once done, do the same change for other platforms (such as `macos`).
70
+
1. Go to the `urls` property and update the URL by replacing all `78.0` occurrences with the version you intend to use.
71
+
Once done, do the same change for other platforms (such as `macos`).
72
72
73
-
Finally, update the `sha256` checksum of the browser archives.
74
-
You can do this by downloading the artifacts from the URLs you just updated, and then running on those files: `sha256 <path>`.
73
+
2. Update the `sha256` checksum of the browser archives.
74
+
You can do this by downloading the artifacts from the URLs you just updated, and then running `shasum` on those files:
0 commit comments