Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove ECG and add events to EEG structure #17

Closed
arnodelorme opened this issue Jul 28, 2023 · 4 comments
Closed

Do not remove ECG and add events to EEG structure #17

arnodelorme opened this issue Jul 28, 2023 · 4 comments

Comments

@arnodelorme
Copy link
Collaborator

It is drastic to remove the ECG channel. Instead keep it by default. Also add the ECG peaks as EEGLAB events.

@amisepa
Copy link
Owner

amisepa commented Aug 1, 2023

Which mode?
It is preserved for removing heart components from EEG data. It is separated into its own structure for HEP and features.

I'm thinking of adding the option to keep or remove the ECG channel in GUI and users can choose.

It's necessary to remove it for HEP analysis, otherwise you have ECG signal in your ERP or time-frequency outputs.

What do you mean by eeglab events? We already have the heartbeats marked as R-peaks in the EEG data (HEP mode).

@arnodelorme
Copy link
Collaborator Author

It would be great if people could run the HEP and HRV modes at the same time. Not a super big deal, but definitely a limitation.

@amisepa
Copy link
Owner

amisepa commented Aug 1, 2023

Ok, that shouldn't be too hard to change that.

@amisepa
Copy link
Owner

amisepa commented Dec 15, 2023

Tricky to run both because of how the toolbox is designed: The EEG preprocessing are slightly different between HEP and features-mode. And for Features, you don't need the ms time synchrony between ECG/PPG and EEG, whereas it is essential for HEP. And HEP and Features are kind of very different applications so not sure it is worth the extra work at the moment.

I added the option to keep the cardiovascular channels via GUI and command line though.

@amisepa amisepa closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants