Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Remove reinstall of hnsw lib #34

Open
tazarov opened this issue Jan 5, 2024 · 0 comments
Open

[Feature Request]: Remove reinstall of hnsw lib #34

tazarov opened this issue Jan 5, 2024 · 0 comments
Assignees
@tazarov
Labels
enhancement New feature or request

Comments

@tazarov
Copy link
Contributor

tazarov commented Jan 5, 2024

Describe the problem

We don't need to reinstall the lib as it is now (0.7.3+) delivered a binary whl.

Describe the proposed solution

Remove pip install --force-reinstall --no-cache-dir chroma-hnswlib from the entry point

Alternatives considered

N/A

Importance

would make my life easier

Additional Information

No response
@tazarov tazarov added the enhancement New feature or request label Jan 5, 2024
@tazarov tazarov self-assigned this Jan 5, 2024
tazarov added a commit that referenced this issue Jan 5, 2024
@tazarov
feat: Removed the hnswlib reinstall at image boot.
ba7839b 
- fixed the default log config path in the entrypoint
- removed unnecessary virtual env install (reduces image size)
- Added optimize hnsw lib build flag for AVX supported CPU architectures

Refs: #34
@tazarov tazarov mentioned this issue Jan 5, 2024
Closed
@tazarov tazarov linked a pull request Jan 5, 2024 that will close this issue
feat: Removed the hnswlib reinstall at image boot #36
Closed
tazarov added a commit that referenced this issue Jan 6, 2024
@tazarov
fix: Fixed Dockerfile hnswlib build issue
1c3c579 
Refs: #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tazarov tazarov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Removed the hnswlib reinstall at image boot amikos-tech/chromadb-chart
1 participant
@tazarov