Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendy-descriptor tries to create a pool of size 0 #256

Open
kvark opened this issue Jan 10, 2020 · 6 comments
Open

rendy-descriptor tries to create a pool of size 0 #256

kvark opened this issue Jan 10, 2020 · 6 comments
Labels
bug Something isn't working diff: easy

Comments

@kvark
Copy link
Member

kvark commented Jan 10, 2020

Reported in gfx-rs/wgpu-rs#149

VALIDATION [VUID-VkDescriptorPoolCreateInfo-poolSizeCount-arraylength (0)] : vkCreateDescriptorPool: parameter pCreateInfo->poolSizeCount must be greater than 0. The Vulkan spec states: poolSizeCount must be greater than 0 (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkDescriptorPoolCreateInfo-poolSizeCount-arraylength)
object info: (type: UNKNOWN, hndl: 0)

Way to reproduce:

git clone https://github.com/gfx-rs/wgpu-rs
cd wgpu-rs
cargo run --example hello-triangle
@zakarumych
Copy link
Member

Not just pool of size 0, but pool without any sizes. Each size is for different descriptor types.
Which means that wgpu tries to allocate descriptor set without any descriptors.

@kvark
Copy link
Member Author

kvark commented Jan 14, 2020

Doesn't Vulkan allow empty descriptor sets and layouts? In this code - gfx-rs/wgpu#240 (comment) , for example the validation layer doesn't complain about the descriptor set layout. Which means, from wgpu perspective this is a valid thing to ask Rendy, and rendy-descriptor should handle this and not try to allocate an empty pool.

@hbina
Copy link

hbina commented May 27, 2020

Is this bug fixed already? I am not able to reproduce

hbina@hbinalapt:~/git/wgpu-rs$ cargo run --example hello-triangle
    Finished dev [unoptimized + debuginfo] target(s) in 0.34s
     Running `target/debug/examples/hello-triangle`
hbina@hbinalapt:~/git/wgpu-rs$ 

@kvark
Copy link
Member Author

kvark commented May 27, 2020

No, we changed the example to not do this any more

@hbina
Copy link

hbina commented May 31, 2020

So where should I look to fix this bug? The repository is enough.

@kvark
Copy link
Member Author

kvark commented May 31, 2020

wgpu has switched to a fork of rendy libraries in https://github.com/gfx-rs/gfx-extras . You can reproduce it by running hello-triangle example in gfx-rs/wgpu-rs@1e3b1a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working diff: easy
Projects
None yet
Development

No branches or pull requests

3 participants