From 2676bda2c31adcbddf01e1b8ca02423c56a1dc0b Mon Sep 17 00:00:00 2001 From: Jonathan Adshead Date: Thu, 14 Sep 2023 14:22:17 -0700 Subject: [PATCH] fix(externals): issue when no one-amex key --- .../__tests__/utils/bundle-external-fallbacks.spec.js | 9 +++++++++ .../utils/bundle-external-fallbacks.js | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/one-app-dev-bundler/__tests__/utils/bundle-external-fallbacks.spec.js b/packages/one-app-dev-bundler/__tests__/utils/bundle-external-fallbacks.spec.js index 66a493f4..f1610d51 100644 --- a/packages/one-app-dev-bundler/__tests__/utils/bundle-external-fallbacks.spec.js +++ b/packages/one-app-dev-bundler/__tests__/utils/bundle-external-fallbacks.spec.js @@ -205,4 +205,13 @@ describe('bundle-external-fallbacks', () => { expect(console.error).toHaveBeenCalledWith('Failed to build fallback for external awesome for browser', error); expect(console.error).toHaveBeenCalledWith('Failed to build fallback for external awesome for node', error); }); + + it('does not fail when no one-amex config', async () => { + readPackageUpSync.mockImplementationOnce(() => ({ + packageJson: {}, + })); + + await bundleExternalFallbacks(); + expect(esbuild.build).not.toHaveBeenCalled(); + }); }); diff --git a/packages/one-app-dev-bundler/utils/bundle-external-fallbacks.js b/packages/one-app-dev-bundler/utils/bundle-external-fallbacks.js index 2101dd4f..9f383d07 100644 --- a/packages/one-app-dev-bundler/utils/bundle-external-fallbacks.js +++ b/packages/one-app-dev-bundler/utils/bundle-external-fallbacks.js @@ -28,7 +28,7 @@ const getExternalLibraryName = (name, version) => [EXTERNAL_PREFIX, snakeCase(na */ export const bundleExternalFallbacks = async () => { const { packageJson } = readPackageUpSync(); - const { 'one-amex': { bundler = {} } } = packageJson; + const { 'one-amex': { bundler = {} } = {} } = packageJson; const { requiredExternals } = bundler; if (