Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRQ: Different standard value of qmin in amep.utils.domain_length. #8

Open
descho00 opened this issue Mar 27, 2024 · 0 comments · May be fixed by #92
Open

FRQ: Different standard value of qmin in amep.utils.domain_length. #8

descho00 opened this issue Mar 27, 2024 · 0 comments · May be fixed by #92
Assignees
@suvendu266
Labels
good first issue Good for newcomers module: utils new feature New feature release: minor Issues that need to be addressed in a minor release status: in progress Someone is working on this issue
Milestone
release v1.1.0

Comments

@descho00
Copy link

Proposed new feature or change:

A useful standard value for qmin in amep.utils.domain_length would be the smallest possible wavenumber due to the finite size of the simulation box instead of None.
@descho00 descho00 added the new feature New feature label Mar 27, 2024
@hechtprojects hechtprojects added good first issue Good for newcomers release: minor Issues that need to be addressed in a minor release status: to do Issues that someone needs to work on module: utils labels Jun 4, 2024
@hechtprojects hechtprojects added this to the release v1.1.0 milestone Jun 4, 2024
@suvendu266 suvendu266 self-assigned this Dec 2, 2024
@kay-ro kay-ro added status: in progress Someone is working on this issue and removed status: to do Issues that someone needs to work on labels Dec 5, 2024
@hechtprojects hechtprojects linked a pull request Dec 11, 2024 that will close this issue
we are closing the issue 8 and 25 #92
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suvendu266 suvendu266

Labels
good first issue Good for newcomers module: utils new feature New feature release: minor Issues that need to be addressed in a minor release status: in progress Someone is working on this issue
Projects
None yet
Milestone
release v1.1.0
Development

Successfully merging a pull request may close this issue.

we are closing the issue 8 and 25 amepproject/amep
4 participants
@hechtprojects @kay-ro @descho00 @suvendu266